From: Jakub Kicinski <kuba@kernel.org>
To: Igor Russkikh <irusskikh@marvell.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Netdev <netdev@vger.kernel.org>
Subject: Re: [EXT] Aquantia ethernet driver suspend/resume issues
Date: Tue, 28 Nov 2023 13:09:51 -0800 [thread overview]
Message-ID: <20231128130951.577af80b@kernel.org> (raw)
In-Reply-To: <9852ab3e-52ce-d55a-8227-c22f6294c61a@marvell.com>
On Tue, 28 Nov 2023 20:18:49 +0100 Igor Russkikh wrote:
> > Another option you can consider is lowering the default ring size.
> > If I'm looking right you default to 4k descriptors for Tx.
> > Is it based on real life experience?
>
> Probably reducing default will help - but again not 100%.
>
> I remember these numbers where chosen mainly to show up good 10Gbps
> line speed in tests, like iperf udp/tcp flood. But these of course
> artificial.
>
> For sure "normal" user can survive even with lower digits.
For Rx under load larger rings are sometimes useful to avoid drops.
But your Tx rings are larger than Rx, which is a bit odd.
I was going to say that with BQL enabled you're very unlikely to ever
use much of the 4k Tx ring, anyway. But you don't have BQL support :S
My free advice is to recheck you really need these sizes and implement
BQL :)
next prev parent reply other threads:[~2023-11-28 21:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 3:04 Aquantia ethernet driver suspend/resume issues Linus Torvalds
2023-11-27 17:29 ` [EXT] " Igor Russkikh
2023-11-27 18:02 ` Linus Torvalds
2023-11-28 17:54 ` Igor Russkikh
2023-11-28 18:37 ` Linus Torvalds
2023-11-27 22:59 ` Jakub Kicinski
2023-11-28 19:18 ` Igor Russkikh
2023-11-28 21:09 ` Jakub Kicinski [this message]
2023-11-30 12:59 ` Igor Russkikh
2024-01-21 21:05 ` Peter Waller
2024-01-23 14:58 ` Igor Russkikh
2024-01-23 15:13 ` Peter Waller
2024-01-23 21:02 ` Peter Waller
2024-01-25 14:58 ` Igor Russkikh
[not found] ` <e8739692-89ea-40e7-b966-bbb4ea5826af@pwaller.net>
2024-02-02 10:35 ` Igor Russkikh
2024-02-02 10:59 ` Peter Waller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128130951.577af80b@kernel.org \
--to=kuba@kernel.org \
--cc=edumazet@google.com \
--cc=irusskikh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).