From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Daniel Golle <daniel@makrotopia.org>,
patchwork-bot+netdevbpf@kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, pabeni@redhat.com, hawk@kernel.org,
ilias.apalodimas@linaro.org, dsahern@gmail.com,
dtatulea@nvidia.com, willemb@google.com, almasrymina@google.com,
shakeelb@google.com
Subject: Re: [PATCH net-next v4 00/13] net: page_pool: add netlink-based introspection
Date: Wed, 29 Nov 2023 16:03:01 -0800 [thread overview]
Message-ID: <20231129160301.4520dbe0@kernel.org> (raw)
In-Reply-To: <CANn89i+srqtEAqaKv=b9xrevL7xPk8MwoMwmudzOshjf0nDxfw@mail.gmail.com>
On Wed, 29 Nov 2023 22:12:49 +0100 Eric Dumazet wrote:
> Please look at the syzbot report
>
> Proposed patch was :
>
> diff --git a/net/core/page_pool_user.c b/net/core/page_pool_user.c
> index 1426434a7e1587797da92f3199c0012559b51271..07becd4eceddcd4be9e5bea6479f8ffd16dac851
> 100644
> --- a/net/core/page_pool_user.c
> +++ b/net/core/page_pool_user.c
> @@ -339,7 +339,8 @@ void page_pool_unlist(struct page_pool *pool)
> mutex_lock(&page_pools_lock);
> netdev_nl_page_pool_event(pool, NETDEV_CMD_PAGE_POOL_DEL_NTF);
> xa_erase(&page_pools, pool->user.id);
> - hlist_del(&pool->user.list);
> + if (!hlist_unhashed(&pool->user.list))
> + hlist_del(&pool->user.list);
> mutex_unlock(&page_pools_lock);
> }
Any reason not to post this fix?
next prev parent reply other threads:[~2023-11-30 0:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 23:07 [PATCH net-next v4 00/13] net: page_pool: add netlink-based introspection Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 01/13] net: page_pool: factor out uninit Jakub Kicinski
2023-11-27 6:56 ` Shakeel Butt
2023-11-26 23:07 ` [PATCH net-next v4 02/13] net: page_pool: id the page pools Jakub Kicinski
2023-11-27 7:07 ` Shakeel Butt
2023-11-28 14:47 ` Paolo Abeni
2023-11-26 23:07 ` [PATCH net-next v4 03/13] net: page_pool: record pools per netdev Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 04/13] net: page_pool: stash the NAPI ID for easier access Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 05/13] eth: link netdev to page_pools in drivers Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 06/13] net: page_pool: add nlspec for basic access to page pools Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 07/13] net: page_pool: implement GET in the netlink API Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 08/13] net: page_pool: add netlink notifications for state changes Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 09/13] net: page_pool: report amount of memory held by page pools Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 10/13] net: page_pool: report when page pool was destroyed Jakub Kicinski
2023-11-26 23:07 ` [PATCH net-next v4 11/13] net: page_pool: expose page pool stats via netlink Jakub Kicinski
2023-11-28 15:01 ` Ilias Apalodimas
2023-11-26 23:07 ` [PATCH net-next v4 12/13] net: page_pool: mute the periodic warning for visible page pools Jakub Kicinski
2023-11-28 15:00 ` Ilias Apalodimas
2023-11-26 23:07 ` [PATCH net-next v4 13/13] tools: ynl: add sample for getting page-pool information Jakub Kicinski
2023-11-28 15:10 ` [PATCH net-next v4 00/13] net: page_pool: add netlink-based introspection patchwork-bot+netdevbpf
2023-11-29 20:10 ` Daniel Golle
2023-11-29 21:12 ` Eric Dumazet
2023-11-30 0:03 ` Jakub Kicinski [this message]
2023-11-30 2:09 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129160301.4520dbe0@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patchwork-bot+netdevbpf@kernel.org \
--cc=shakeelb@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).