From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5628151002 for ; Thu, 30 Nov 2023 17:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qXzi1eHz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D297AC433C7; Thu, 30 Nov 2023 17:39:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701365980; bh=CZqrdkZ4ENP7qgExXIa/F+1bLjJzCwWKd/rStNYLK4I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qXzi1eHz/tXTGi+nFE43btAjPSUpchZUG/OlV24ZeBg4ivSjo5qc1RGo7plSB70ne k9E6F2fZJcES6flH1Bx7Y8JZR181nBcwd3v8EQXeoH6pur2Gxx/dSBJB9Y6IhvIhxI mQbuu8W+hyXkctRO73VOejZhQd4fuzYp7jTzF14Xx5uDJqvEPus39r8T+b3bPzAR+y SKpSvoTRnOHAHzttuuz9GPpxWYDOEkpQju/82n5VkAqT3A/UyWyhf6XhY6G6abVuKJ wW0UXtdV1GkBbUYOuxCjKJrg9nAjJVFviqAsyLugXsBlrjQeqZziURAE+hUoeWVLbG AfoppU5G5InSQ== Date: Thu, 30 Nov 2023 09:39:39 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net, edumazet@google.com, corbet@lwn.net Subject: Re: [patch net-next] docs: netlink: add NLMSG_DONE message format for doit actions Message-ID: <20231130093939.06a987cb@kernel.org> In-Reply-To: References: <20231128151916.780588-1-jiri@resnulli.us> <20231128073059.314ed76b@kernel.org> <20231129071656.6de3f298@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 30 Nov 2023 14:30:36 +0100 Jiri Pirko wrote: > >connector is a really bad example, the doc would have to say "some > >families use NLMSG_DONE as an actual message type which may have pretty > >much anything attached to it". It's not worth it, sorry. > > The existing documentation confuses uapi users (I have sample). > They expect error with NLMSG_DONE. I hate this so much. How about we say: Note that some families may issue custom NLMSG_DONE messages, in which case the payload is implementation-specific.