From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CE191172F; Fri, 1 Dec 2023 06:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oKchjUxM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A04EC433CA; Fri, 1 Dec 2023 06:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701413488; bh=kQXX0N9DHac4wzjyMFagAgIKtsFvQDfa4+CaUJ9nQsI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oKchjUxMO4ZeSNCNFQcsENqGG2C57VOtaGye4yTBy8D8O1YNMEI6Nsfs3Lrnlx3Jv g+ifoWreBQS//LHF6/8y/RnRmRGq4eJgczq8DmuT5IUtNRM+VztyYxi7AVmXuzKHC7 oGElAYKnTYE1xyM+Y6bnhCvoljI0yjhgGPwHQdEjXlccYdqVijw7encBVIA3/bMtAc T8jzMwN0KLPiKSm/Roht8hvPXIp8We3kUuEmxnDETwaxcMU8y2vfAxA9lQ0+ZJ42pO vstS6H2qZ31UvsRk8mEnhZDBVhK17OdcvIfD8ck+FlGcr+hUYPDREAUh1fsHVTVu/L 40oiH5CYhUXLw== Date: Thu, 30 Nov 2023 22:51:27 -0800 From: Jakub Kicinski To: "Michalik, Michal" Cc: "netdev@vger.kernel.org" , "vadim.fedorenko@linux.dev" , "Kubalewski, Arkadiusz" , "jonathan.lemon@gmail.com" , "pabeni@redhat.com" , poros , "Olech, Milena" , mschmidt , "linux-clk@vger.kernel.org" , "bvanassche@acm.org" , "davem@davemloft.net" , "edumazet@google.com" Subject: Re: [PATCH RFC net-next v4 2/2] selftests/dpll: add DPLL system integration selftests Message-ID: <20231130225127.1b56ffca@kernel.org> In-Reply-To: References: <20231123105243.7992-1-michal.michalik@intel.com> <20231123105243.7992-3-michal.michalik@intel.com> <20231129093951.3be1bd8b@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 30 Nov 2023 17:46:37 +0000 Michalik, Michal wrote: > > Did you try to run it in vmtest or virtme-ng? > > https://www.youtube.com/watch?v=NT-325hgXjY > > https://lpc.events/event/17/contributions/1506/attachments/1143/2441/virtme-ng.pdf > > > > I'm thinking of using those for continuous testing, curious all > > the Python setup works okay with them. > > Very interesting idea, I didn't try to use those - will get familiar with that and > see if I can make any improvements to go with vmtest/virtme-ng before I will send > out the RFC v5. LMK how it goes. I tried using both today and they work fine if I let them build the kernel, but if I tried to use my own kernel build they just hang :( > > Did you see what the sdsi test does? It seems to assume everything > > is installed locally, without the venv. I wonder if that may be simpler > > to get going with vmtest? > > To be honest I did not see that. I agree that this is a simpler solution, but I am > not sure if that is not "too simple". What I mean, I'm not sure who wrote the sdsi > tests, but maybe they were not aware about the Python best practices? Python used > to be my first language, and I would vote for using the venvs if you asked me. > I understand that it haven't been done before, but we are here to try to improve > the things, yes? I think I already asked how long the setup takes but my only concern is that the setup will be slower, and less useful during development. > Of course if you outvote me, I won't act as Tadeusz Rejtan in > Matejko's painting "The Fall of Poland" and just remove the virtual environments. :) :D The infallible strategy of showing a nipple. https://www.youtube.com/watch?v=lY0V65YWEIA&t=50s