From: Jakub Kicinski <kuba@kernel.org>
To: Bert Karwatzki <spasswolf@web.de>
Cc: almasrymina@google.com, edumazet@google.com, hawk@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: page_pool: Fix NULL pointer dereference in page_pool_unlist()
Date: Thu, 30 Nov 2023 23:08:12 -0800 [thread overview]
Message-ID: <20231130230812.16461d0f@kernel.org> (raw)
In-Reply-To: <20231130192542.4503-1-spasswolf@web.de>
On Thu, 30 Nov 2023 20:25:42 +0100 Bert Karwatzki wrote:
> When the the hlist_node pool->user.list is in an in an unhashed state,
> calling hlist_del() leads to a NULL pointer dereference. This happens
> e. g. when rmmod'ing the mt7921e (mediatek wifi driver) kernel module.
> An additional check fixes the issue.
>
> Fixes: 083772c9f972dc ("net: page_pool: record pools per netdev")
>
> Signed-off-by: Bert Karwatzki <spasswolf@web.de>
Thanks for the patch, we got a couple of similar submissions,
and merged the first one to be posted.. should be fixed in net-next now.
--
pw-bot: na
prev parent reply other threads:[~2023-12-01 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 19:25 [PATCH] net: page_pool: Fix NULL pointer dereference in page_pool_unlist() Bert Karwatzki
2023-12-01 7:08 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130230812.16461d0f@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=spasswolf@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).