From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F6C8C130 for ; Fri, 1 Dec 2023 07:08:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DcvyVC/a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4141FC433C8; Fri, 1 Dec 2023 07:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701414493; bh=kkDlSi8LK9wnO0BxtoNklTwo0Po3lzBpozTfDh5KYnQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DcvyVC/azyDijmRL8how/2ktMXVEwKIFt5n4L6TFDZ9/YbVs6t4DBQJGb3xWXQNw7 CThYeS4obQ4V9I/mInL+2uX5bMRuYkx1C7EXpUoQjE5zAtYb96Wu6svE1ppqEayKOK kH+frqVB83WDfjMVmYTBQNs/I6VCXLdIP0I7dagdGgNMI01jHBUT4dzH3uQ04Aoepz n0jYCcIWo0WdcN3ZnK/8NM7yCBX0LcKDOCd941LyLvKpELhfV5R3VmGFBZLLOrIaU+ LbI1B6Y3cByx5dO/oKqPn2iRH921YFJOnqF0QMeDde6/4n3skcm9FvT/OIFJT53KlL ZMxfwsEVqJa0A== Date: Thu, 30 Nov 2023 23:08:12 -0800 From: Jakub Kicinski To: Bert Karwatzki Cc: almasrymina@google.com, edumazet@google.com, hawk@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: page_pool: Fix NULL pointer dereference in page_pool_unlist() Message-ID: <20231130230812.16461d0f@kernel.org> In-Reply-To: <20231130192542.4503-1-spasswolf@web.de> References: <20231130192542.4503-1-spasswolf@web.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 30 Nov 2023 20:25:42 +0100 Bert Karwatzki wrote: > When the the hlist_node pool->user.list is in an in an unhashed state, > calling hlist_del() leads to a NULL pointer dereference. This happens > e. g. when rmmod'ing the mt7921e (mediatek wifi driver) kernel module. > An additional check fixes the issue. > > Fixes: 083772c9f972dc ("net: page_pool: record pools per netdev") > > Signed-off-by: Bert Karwatzki Thanks for the patch, we got a couple of similar submissions, and merged the first one to be posted.. should be fixed in net-next now. -- pw-bot: na