From: Jakub Kicinski <kuba@kernel.org>
To: "Nambiar, Amritha" <amritha.nambiar@intel.com>
Cc: Michael Chan <michael.chan@broadcom.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<edumazet@google.com>, <ast@kernel.org>, <sdf@google.com>,
<lorenzo@kernel.org>, <tariqt@nvidia.com>, <daniel@iogearbox.net>,
<anthony.l.nguyen@intel.com>, <lucien.xin@gmail.com>,
<sridhar.samudrala@intel.com>,
Andrew Gospodarek <gospo@broadcom.com>
Subject: Re: [net-next PATCH v10 11/11] eth: bnxt: link NAPI instances to queues and IRQs
Date: Thu, 30 Nov 2023 23:21:39 -0800 [thread overview]
Message-ID: <20231130232139.25b6cba1@kernel.org> (raw)
In-Reply-To: <d4d8769b-a96b-42c6-9d76-92174eb638a1@intel.com>
On Thu, 30 Nov 2023 12:53:50 -0800 Nambiar, Amritha wrote:
> > This will include the XDP TX rings that are internal to the driver. I
> > think we need to exclude these XDP rings and do something like this:
> >
> > if (i > bp->tx_nr_rings_xdp)
> > netif_queue_set_napi(bp->dev, i - bp->tx_nr_rings_xdp,
> > NETDEV_QUEUE_TYPE_TX, &txr->bnapi->napi);
>
> Okay, will wait for Jakub's response as well. I can make this change in
> the next version (after waiting for other comments on the rest of the
> series), but I may not be able to test this on bnxt.
No extra comments from me, thanks for taking care of the update.
--
pw-bot: cr
prev parent reply other threads:[~2023-12-01 7:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 0:27 [net-next PATCH v10 00/11] Introduce queue and NAPI support in netdev-genl (Was: Introduce NAPI queues support) Amritha Nambiar
2023-11-30 0:27 ` [net-next PATCH v10 01/11] netdev-genl: spec: Extend netdev netlink spec in YAML for queue Amritha Nambiar
2023-11-30 0:27 ` [net-next PATCH v10 02/11] net: Add queue and napi association Amritha Nambiar
2023-11-30 0:27 ` [net-next PATCH v10 03/11] ice: Add support in the driver for associating queue with napi Amritha Nambiar
2023-11-30 0:27 ` [net-next PATCH v10 04/11] netdev-genl: Add netlink framework functions for queue Amritha Nambiar
2023-11-30 0:27 ` [net-next PATCH v10 05/11] netdev-genl: spec: Extend netdev netlink spec in YAML for NAPI Amritha Nambiar
2023-11-30 0:27 ` [net-next PATCH v10 06/11] netdev-genl: Add netlink framework functions for napi Amritha Nambiar
2023-11-30 0:28 ` [net-next PATCH v10 07/11] netdev-genl: spec: Add irq in netdev netlink YAML spec Amritha Nambiar
2023-11-30 0:28 ` [net-next PATCH v10 08/11] net: Add NAPI IRQ support Amritha Nambiar
2023-11-30 0:28 ` [net-next PATCH v10 09/11] netdev-genl: spec: Add PID in netdev netlink YAML spec Amritha Nambiar
2023-11-30 0:28 ` [net-next PATCH v10 10/11] netdev-genl: Add PID for the NAPI thread Amritha Nambiar
2023-11-30 0:28 ` [net-next PATCH v10 11/11] eth: bnxt: link NAPI instances to queues and IRQs Amritha Nambiar
2023-11-30 5:52 ` Michael Chan
2023-11-30 20:53 ` Nambiar, Amritha
2023-12-01 7:21 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130232139.25b6cba1@kernel.org \
--to=kuba@kernel.org \
--cc=amritha.nambiar@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=lorenzo@kernel.org \
--cc=lucien.xin@gmail.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=sridhar.samudrala@intel.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).