From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: linux-nfs@vger.kernel.org, lorenzo.bianconi@redhat.com,
neilb@suse.de, netdev@vger.kernel.org, jlayton@kernel.org
Subject: Re: [PATCH v5 2/3] NFSD: convert write_version to netlink command
Date: Thu, 30 Nov 2023 23:28:22 -0800 [thread overview]
Message-ID: <20231130232822.1dee5243@kernel.org> (raw)
In-Reply-To: <ZWhksS5C6mcvVPEN@lore-desk>
On Thu, 30 Nov 2023 11:32:17 +0100 Lorenzo Bianconi wrote:
> > u8? I guess...
>
> here we need just 0 or 1 I would say. Do you suggest create something like an
> enum?
Ah, sorry, thought I must have already complained to you about this
in the past - netlink aligns everything to 4B. So u8 or u16 or u32
it's all the same size at the message level. For the <u32 types some
bytes are just treated as padding instead of being useful.
But if you explicitly need only 0/1 then it doesn't matter.
next prev parent reply other threads:[~2023-12-01 7:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 17:12 [PATCH v5 0/3] convert write_threads, write_version and write_ports to netlink commands Lorenzo Bianconi
2023-11-29 17:12 ` [PATCH v5 1/3] NFSD: convert write_threads to netlink command Lorenzo Bianconi
2023-11-29 18:13 ` Jeff Layton
2023-11-29 18:31 ` Chuck Lever
2023-11-30 0:32 ` Jakub Kicinski
2023-11-29 17:12 ` [PATCH v5 2/3] NFSD: convert write_version " Lorenzo Bianconi
2023-11-29 18:23 ` Jeff Layton
2023-11-30 9:45 ` Lorenzo Bianconi
2023-11-30 16:17 ` Jeff Layton
2023-11-30 16:11 ` Chuck Lever
2023-11-30 16:25 ` Lorenzo Bianconi
2023-11-30 16:29 ` Chuck Lever
2023-11-30 16:32 ` Lorenzo Bianconi
2023-11-30 0:28 ` Jakub Kicinski
2023-11-30 10:32 ` Lorenzo Bianconi
2023-12-01 7:28 ` Jakub Kicinski [this message]
2023-12-05 20:33 ` Simon Horman
2023-11-29 17:12 ` [PATCH v5 3/3] NFSD: convert write_ports " Lorenzo Bianconi
2023-11-29 18:28 ` Jeff Layton
2023-11-30 9:57 ` Lorenzo Bianconi
2023-11-30 16:22 ` Jeff Layton
2023-11-30 16:55 ` Jeff Layton
2023-11-30 17:39 ` Chuck Lever
2023-11-30 18:01 ` Jeff Layton
2023-11-30 18:34 ` Chuck Lever
2023-12-05 20:37 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130232822.1dee5243@kernel.org \
--to=kuba@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).