* [patch net-next v2] docs: netlink: add NLMSG_DONE message format for doit actions
@ 2023-12-01 15:34 Jiri Pirko
2023-12-01 16:38 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Pirko @ 2023-12-01 15:34 UTC (permalink / raw)
To: netdev; +Cc: kuba, pabeni, davem, edumazet, corbet
From: Jiri Pirko <jiri@nvidia.com>
In case NLMSG_DONE message is sent as a reply to doit action, multiple
kernel implementation do not send anything else than struct nlmsghdr.
Add this note to the Netlink intro documentation.
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
---
v1->v2:
- Changed the note completely
---
Documentation/userspace-api/netlink/intro.rst | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/userspace-api/netlink/intro.rst b/Documentation/userspace-api/netlink/intro.rst
index 7b1d401210ef..e0efa75db94b 100644
--- a/Documentation/userspace-api/netlink/intro.rst
+++ b/Documentation/userspace-api/netlink/intro.rst
@@ -234,6 +234,10 @@ ACK attributes may be present::
| ** optionally extended ACK |
----------------------------------------------
+Note that some implementations may issue custom ``NLMSG_DONE`` messages
+in reply to ``do`` action requests. In that case the payload is
+implementation-specific and may also be avoided.
+
.. _res_fam:
Resolving the Family ID
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch net-next v2] docs: netlink: add NLMSG_DONE message format for doit actions
2023-12-01 15:34 [patch net-next v2] docs: netlink: add NLMSG_DONE message format for doit actions Jiri Pirko
@ 2023-12-01 16:38 ` Jakub Kicinski
2023-12-01 18:01 ` Jiri Pirko
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2023-12-01 16:38 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev, pabeni, davem, edumazet, corbet
On Fri, 1 Dec 2023 16:34:09 +0100 Jiri Pirko wrote:
> +Note that some implementations may issue custom ``NLMSG_DONE`` messages
> +in reply to ``do`` action requests. In that case the payload is
> +implementation-specific and may also be avoided.
"avoided" does not read quite right here, perhaps a native speaker
will disagree, but I'd s/avoided/absent/
Feel free to skip the 24h wait if you agree
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch net-next v2] docs: netlink: add NLMSG_DONE message format for doit actions
2023-12-01 16:38 ` Jakub Kicinski
@ 2023-12-01 18:01 ` Jiri Pirko
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2023-12-01 18:01 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev, pabeni, davem, edumazet, corbet
Fri, Dec 01, 2023 at 05:38:03PM CET, kuba@kernel.org wrote:
>On Fri, 1 Dec 2023 16:34:09 +0100 Jiri Pirko wrote:
>> +Note that some implementations may issue custom ``NLMSG_DONE`` messages
>> +in reply to ``do`` action requests. In that case the payload is
>> +implementation-specific and may also be avoided.
>
>"avoided" does not read quite right here, perhaps a native speaker
>will disagree, but I'd s/avoided/absent/
>Feel free to skip the 24h wait if you agree
Okay. Will change and send v3. Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-01 18:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-01 15:34 [patch net-next v2] docs: netlink: add NLMSG_DONE message format for doit actions Jiri Pirko
2023-12-01 16:38 ` Jakub Kicinski
2023-12-01 18:01 ` Jiri Pirko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).