From: Jakub Kicinski <kuba@kernel.org>
To: Pedro Tammela <pctammela@mojatatu.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
jiri@resnulli.us, mleitner@redhat.com
Subject: Re: [PATCH net-next 0/4] net/sched: act_api: contiguous action arrays
Date: Fri, 1 Dec 2023 09:33:17 -0800 [thread overview]
Message-ID: <20231201093317.017c6424@kernel.org> (raw)
In-Reply-To: <20231130152041.13513-1-pctammela@mojatatu.com>
On Thu, 30 Nov 2023 12:20:37 -0300 Pedro Tammela wrote:
> When dealing with action arrays in act_api it's natural to ask if they
> are always contiguous (no NULL pointers in between). Yes, they are in
> all cases so far, so make use of the already present tcf_act_for_each_action
> macro to explicitly document this assumption.
>
> There was an instance where it was not, but it was refactorable (patch 2)
> to make the array contiguous.
Hi Pedro, this appears not to apply.
--
pw-bot: cr
next prev parent reply other threads:[~2023-12-01 17:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 15:20 [PATCH net-next 0/4] net/sched: act_api: contiguous action arrays Pedro Tammela
2023-11-30 15:20 ` [PATCH net-next 1/4] net/sched: act_api: use tcf_act_for_each_action Pedro Tammela
2023-11-30 15:20 ` [PATCH net-next 2/4] net/sched: act_api: avoid non-contiguous action array Pedro Tammela
2023-11-30 15:20 ` [PATCH net-next 3/4] net/sched: act_api: stop loop over ops array on NULL in tcf_action_init Pedro Tammela
2023-11-30 15:20 ` [PATCH net-next 4/4] net/sched: act_api: use tcf_act_for_each_action in tcf_idr_insert_many Pedro Tammela
2023-12-01 17:33 ` Jakub Kicinski [this message]
2023-12-01 17:34 ` [PATCH net-next 0/4] net/sched: act_api: contiguous action arrays Pedro Tammela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201093317.017c6424@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox