From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<brett.creeley@amd.com>, <drivers@pensando.io>
Subject: Re: [PATCH net 0/7] ionic: small driver fixes
Date: Fri, 1 Dec 2023 17:42:23 -0800 [thread overview]
Message-ID: <20231201174223.34c6ac58@kernel.org> (raw)
In-Reply-To: <20231201000519.13363-1-shannon.nelson@amd.com>
On Thu, 30 Nov 2023 16:05:12 -0800 Shannon Nelson wrote:
> This is a collection of small fixes for the ionic driver,
> mostly code cleanup items.
Hm, looks cleanup-y indeed. Majority of this looks like net-next
material, really.
1 - fine for net
2 - perf optimization, we generally follow stable rules, which say:
Serious issues as reported by a user of a distribution kernel may
also be considered if they fix a notable performance or
interactivity issue. As these fixes are not as obvious and have a
higher risk of a subtle regression they should only be submitted by
a distribution kernel maintainer and include an addendum linking to
a bugzilla entry if it exists and additional information on the
user-visible impact.
I doubt serious "user-visible impact" will be the case here, however.
3 - I don't see how this matters, netdev is not registered, locks are
not initialized, who's going to access that pointer?
4 - cleanup / nop
5 - cleanup / nop
6 - fine for net
7 - optimization and a minor one at that
I appreciate the diligent Fixes tags but I'm afraid we need to be a bit
more judicious in what we consider a fix.
--
pw-bot: cr
next prev parent reply other threads:[~2023-12-02 1:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 0:05 [PATCH net 0/7] ionic: small driver fixes Shannon Nelson
2023-12-01 0:05 ` [PATCH net 1/7] ionic: fix snprintf format length warning Shannon Nelson
2023-12-01 0:05 ` [PATCH net 2/7] ionic: Use cached VF attributes Shannon Nelson
2023-12-01 0:05 ` [PATCH net 3/7] ionic: set ionic ptr before setting up ethtool ops Shannon Nelson
2023-12-01 0:05 ` [PATCH net 4/7] ionic: Don't check null when calling vfree() Shannon Nelson
2023-12-01 0:05 ` [PATCH net 5/7] ionic: Make the check for Tx HW timestamping more obvious Shannon Nelson
2023-12-01 0:05 ` [PATCH net 6/7] ionic: Fix dim work handling in split interrupt mode Shannon Nelson
2023-12-01 0:05 ` [PATCH net 7/7] ionic: Re-arrange ionic_intr_info struct for cache perf Shannon Nelson
2023-12-01 4:19 ` [PATCH net 0/7] ionic: small driver fixes Florian Fainelli
2023-12-01 17:20 ` Nelson, Shannon
2023-12-02 1:42 ` Jakub Kicinski [this message]
2023-12-04 18:23 ` Nelson, Shannon
2023-12-04 18:35 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201174223.34c6ac58@kernel.org \
--to=kuba@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).