From: Jakub Kicinski <kuba@kernel.org>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org,
Jacob Keller <jacob.e.keller@intel.com>,
donald.hunter@redhat.com
Subject: Re: [PATCH net-next v1 4/6] tools/net/ynl: Add binary and pad support to structs for tc
Date: Fri, 1 Dec 2023 18:06:46 -0800 [thread overview]
Message-ID: <20231201180646.7d3c851f@kernel.org> (raw)
In-Reply-To: <20231130214959.27377-5-donald.hunter@gmail.com>
On Thu, 30 Nov 2023 21:49:56 +0000 Donald Hunter wrote:
> The tc netlink-raw family needs binary and pad types for several
> qopt C structs. Add support for them to ynl.
Nice reuse of the concept of "pad", I don't see why not:
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
> + value = msg.raw[offset:offset+m.len]
What does Python style guide say about spaces around '+' here?
I tend to use C style, no idea if it's right.
next prev parent reply other threads:[~2023-12-02 2:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 21:49 [PATCH net-next v1 0/6] tools/net/ynl: Add 'sub-message' support to ynl Donald Hunter
2023-11-30 21:49 ` [PATCH net-next v1 1/6] doc/netlink: Add bitfield32, s8, s16 to the netlink-raw schema Donald Hunter
2023-12-02 1:47 ` Jakub Kicinski
2023-11-30 21:49 ` [PATCH net-next v1 2/6] doc/netlink: Add sub-message support to netlink-raw Donald Hunter
2023-12-02 1:53 ` Jakub Kicinski
2023-12-04 15:58 ` Donald Hunter
2023-11-30 21:49 ` [PATCH net-next v1 3/6] tools/net/ynl: Add 'sub-message' attribute decoding to ynl Donald Hunter
2023-12-02 2:00 ` Jakub Kicinski
2023-12-04 15:59 ` Donald Hunter
2023-11-30 21:49 ` [PATCH net-next v1 4/6] tools/net/ynl: Add binary and pad support to structs for tc Donald Hunter
2023-12-02 2:06 ` Jakub Kicinski [this message]
2023-12-04 16:18 ` Donald Hunter
2023-12-04 18:21 ` Jakub Kicinski
2023-11-30 21:49 ` [PATCH net-next v1 5/6] doc/netlink/specs: add sub-message type to rt_link family Donald Hunter
2023-12-02 2:10 ` Jakub Kicinski
2023-12-04 16:22 ` Donald Hunter
2023-11-30 21:49 ` [PATCH net-next v1 6/6] doc/netlink/specs: Add a spec for tc Donald Hunter
2023-12-02 2:13 ` Jakub Kicinski
2023-12-04 16:27 ` Donald Hunter
2023-12-04 18:32 ` Jakub Kicinski
2023-12-04 22:38 ` Donald Hunter
2023-12-02 1:50 ` [PATCH net-next v1 0/6] tools/net/ynl: Add 'sub-message' support to ynl patchwork-bot+netdevbpf
2023-12-02 2:15 ` Jakub Kicinski
2023-12-04 15:54 ` Donald Hunter
2023-12-04 18:33 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2023-11-30 17:13 [PATCH net-next v1 4/6] tools/net/ynl: Add binary and pad support to structs for tc Donald Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201180646.7d3c851f@kernel.org \
--to=kuba@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).