From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 590BE156EB;
	Sun,  3 Dec 2023 17:50:21 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A7Y/TuEp"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A9D5C433C8;
	Sun,  3 Dec 2023 17:50:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1701625821;
	bh=KaCBA7aWetgNynrDp9I/L5TG0YXmHua23gxLEqwslEw=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=A7Y/TuEpYv7g7QuAjMRI8Pgilq10cC6gmaahN0JJV8K4PcZgm5SOqgVtdyu3VEXqp
	 6iM8eukVtdjbPI+a2jeunwaut2pyMLHEaS3ryk43p74agXW/oFyY8J3IuUg0fN46Ms
	 LS4DikhG8FmNVdryCKzC6wY1FXXavqZzCWoHRAJn1sQTFh+VKK6VW2kyE4uJWIoP2E
	 7FWJs0s0aqlCyZUt7qeRhPAbuwqIbZE0UwchkYuO9iUmB0P1t26l91qfSae2rn/pBe
	 vAdoca4MJ0wd9M4Se4RRPH8HHJlWFUlBulORCqW/YJhYfh3X0/tycYDEJDV1XpSz2e
	 2PFfZ/EDXmL7g==
Date: Sun, 3 Dec 2023 17:50:15 +0000
From: Simon Horman <horms@kernel.org>
To: Shifeng Li <lishifeng@sangfor.com.cn>
Cc: saeedm@nvidia.com, leon@kernel.org, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	ogerlitz@mellanox.com, netdev@vger.kernel.org,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	dinghui@sangfor.com.cn, lishifeng1992@126.com
Subject: Re: [PATCH] net/mlx5e: Fix slab-out-of-bounds in
 mlx5_query_nic_vport_mac_list()
Message-ID: <20231203175015.GP50400@kernel.org>
References: <20231130094656.894412-1-lishifeng@sangfor.com.cn>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231130094656.894412-1-lishifeng@sangfor.com.cn>

On Thu, Nov 30, 2023 at 01:46:56AM -0800, Shifeng Li wrote:
> Out_sz that the size of out buffer is calculated using query_nic_vport
> _context_in structure when driver query the MAC list. However query_nic
> _vport_context_in structure is smaller than query_nic_vport_context_out.
> When allowed_list_size is greater than 96, calling ether_addr_copy() will
> trigger an slab-out-of-bounds.
> 
> [ 1170.055866] BUG: KASAN: slab-out-of-bounds in mlx5_query_nic_vport_mac_list+0x481/0x4d0 [mlx5_core]
> [ 1170.055869] Read of size 4 at addr ffff88bdbc57d912 by task kworker/u128:1/461
> [ 1170.055870]
> [ 1170.055932] Workqueue: mlx5_esw_wq esw_vport_change_handler [mlx5_core]
> [ 1170.055936] Call Trace:
> [ 1170.055949]  dump_stack+0x8b/0xbb
> [ 1170.055958]  print_address_description+0x6a/0x270
> [ 1170.055961]  kasan_report+0x179/0x2c0
> [ 1170.056061]  mlx5_query_nic_vport_mac_list+0x481/0x4d0 [mlx5_core]
> [ 1170.056162]  esw_update_vport_addr_list+0x2c5/0xcd0 [mlx5_core]
> [ 1170.056257]  esw_vport_change_handle_locked+0xd08/0x1a20 [mlx5_core]
> [ 1170.056377]  esw_vport_change_handler+0x6b/0x90 [mlx5_core]
> [ 1170.056381]  process_one_work+0x65f/0x12d0
> [ 1170.056383]  worker_thread+0x87/0xb50
> [ 1170.056390]  kthread+0x2e9/0x3a0
> [ 1170.056394]  ret_from_fork+0x1f/0x40
> 
> Fixes: e16aea2744ab ("net/mlx5: Introduce access functions to modify/query vport mac lists")
> Cc: Ding Hui <dinghui@sangfor.com.cn>
> Signed-off-by: Shifeng Li <lishifeng@sangfor.com.cn>

Hi,

I am unsure how you calculated the 96 figure above.
But in any case I agree that the cited patch introduced
the mismatch that you describe.

Reviewed-by: Simon Horman <horms@kernel.org>