From: Saeed Mahameed <saeed@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>
Subject: [net V2 02/14] net/mlx5e: Ensure that IPsec sequence packet number starts from 1
Date: Mon, 4 Dec 2023 22:13:15 -0800 [thread overview]
Message-ID: <20231205061327.44638-3-saeed@kernel.org> (raw)
In-Reply-To: <20231205061327.44638-1-saeed@kernel.org>
From: Leon Romanovsky <leonro@nvidia.com>
According to RFC4303, section "3.3.3. Sequence Number Generation",
the first packet sent using a given SA will contain a sequence
number of 1.
However if user didn't set seq/oseq, the HW used zero as first sequence
packet number. Such misconfiguration causes to drop of first packet
if replay window protection was enabled in SA.
To fix it, set sequence number to be at least 1.
Fixes: 7db21ef4566e ("net/mlx5e: Set IPsec replay sequence numbers")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
index 4028932d93ce..914b9e6eb7db 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
@@ -121,7 +121,14 @@ static bool mlx5e_ipsec_update_esn_state(struct mlx5e_ipsec_sa_entry *sa_entry)
if (x->xso.type == XFRM_DEV_OFFLOAD_CRYPTO)
esn_msb = xfrm_replay_seqhi(x, htonl(seq_bottom));
- sa_entry->esn_state.esn = esn;
+ if (sa_entry->esn_state.esn_msb)
+ sa_entry->esn_state.esn = esn;
+ else
+ /* According to RFC4303, section "3.3.3. Sequence Number Generation",
+ * the first packet sent using a given SA will contain a sequence
+ * number of 1.
+ */
+ sa_entry->esn_state.esn = max_t(u32, esn, 1);
sa_entry->esn_state.esn_msb = esn_msb;
if (unlikely(overlap && seq_bottom < MLX5E_IPSEC_ESN_SCOPE_MID)) {
--
2.43.0
next prev parent reply other threads:[~2023-12-05 6:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 6:13 [pull request][net V2 00/14] mlx5 fixes 2023-12-04 Saeed Mahameed
2023-12-05 6:13 ` [net V2 01/14] net/mlx5e: Honor user choice of IPsec replay window size Saeed Mahameed
2023-12-05 6:13 ` Saeed Mahameed [this message]
2023-12-05 6:13 ` [net V2 03/14] net/mlx5e: Unify esw and normal IPsec status table creation/destruction Saeed Mahameed
2023-12-05 6:13 ` [net V2 04/14] net/mlx5e: Remove exposure of IPsec RX flow steering struct Saeed Mahameed
2023-12-05 6:13 ` [net V2 05/14] net/mlx5e: Add IPsec and ASO syndromes check in HW Saeed Mahameed
2023-12-05 6:13 ` [net V2 06/14] net/mlx5e: Tidy up IPsec NAT-T SA discovery Saeed Mahameed
2023-12-05 6:13 ` [net V2 07/14] net/mlx5e: Reduce eswitch mode_lock protection context Saeed Mahameed
2023-12-05 6:13 ` [net V2 08/14] net/mlx5e: Check the number of elements before walk TC rhashtable Saeed Mahameed
2023-12-08 4:47 ` Herbert Xu
2023-12-08 5:32 ` Jianbo Liu
2023-12-05 6:13 ` [net V2 09/14] net/mlx5e: Disable IPsec offload support if not FW steering Saeed Mahameed
2023-12-05 6:13 ` [net V2 10/14] net/mlx5e: Fix possible deadlock on mlx5e_tx_timeout_work Saeed Mahameed
2023-12-05 6:13 ` [net V2 11/14] net/mlx5e: TC, Don't offload post action rule if not supported Saeed Mahameed
2023-12-05 6:13 ` [net V2 12/14] net/mlx5: Nack sync reset request when HotPlug is enabled Saeed Mahameed
2023-12-05 6:13 ` [net V2 13/14] net/mlx5e: Check netdev pointer before checking its net ns Saeed Mahameed
2023-12-05 6:13 ` [net V2 14/14] net/mlx5: Fix a NULL vs IS_ERR() check Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205061327.44638-3-saeed@kernel.org \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).