From: Saeed Mahameed <saeed@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Jianbo Liu <jianbol@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>
Subject: [net V2 08/14] net/mlx5e: Check the number of elements before walk TC rhashtable
Date: Mon, 4 Dec 2023 22:13:21 -0800 [thread overview]
Message-ID: <20231205061327.44638-9-saeed@kernel.org> (raw)
In-Reply-To: <20231205061327.44638-1-saeed@kernel.org>
From: Jianbo Liu <jianbol@nvidia.com>
After IPSec TX tables are destroyed, the flow rules in TC rhashtable,
which have the destination to IPSec, are restored to the original
one, the uplink.
However, when the device is in switchdev mode and unload driver with
IPSec rules configured, TC rhashtable cleanup is done before IPSec
cleanup, which means tc_ht->tbl is already freed when walking TC
rhashtable, in order to restore the destination. So add the checking
before walking to avoid unexpected behavior.
Fixes: d1569537a837 ("net/mlx5e: Modify and restore TC rules for IPSec TX rules")
Signed-off-by: Jianbo Liu <jianbol@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/esw/ipsec_fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/ipsec_fs.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/ipsec_fs.c
index 5a0047bdcb51..190f10aba170 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/esw/ipsec_fs.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/ipsec_fs.c
@@ -152,7 +152,7 @@ void mlx5_esw_ipsec_restore_dest_uplink(struct mlx5_core_dev *mdev)
xa_for_each(&esw->offloads.vport_reps, i, rep) {
rpriv = rep->rep_data[REP_ETH].priv;
- if (!rpriv || !rpriv->netdev)
+ if (!rpriv || !rpriv->netdev || !atomic_read(&rpriv->tc_ht.nelems))
continue;
rhashtable_walk_enter(&rpriv->tc_ht, &iter);
--
2.43.0
next prev parent reply other threads:[~2023-12-05 6:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 6:13 [pull request][net V2 00/14] mlx5 fixes 2023-12-04 Saeed Mahameed
2023-12-05 6:13 ` [net V2 01/14] net/mlx5e: Honor user choice of IPsec replay window size Saeed Mahameed
2023-12-05 6:13 ` [net V2 02/14] net/mlx5e: Ensure that IPsec sequence packet number starts from 1 Saeed Mahameed
2023-12-05 6:13 ` [net V2 03/14] net/mlx5e: Unify esw and normal IPsec status table creation/destruction Saeed Mahameed
2023-12-05 6:13 ` [net V2 04/14] net/mlx5e: Remove exposure of IPsec RX flow steering struct Saeed Mahameed
2023-12-05 6:13 ` [net V2 05/14] net/mlx5e: Add IPsec and ASO syndromes check in HW Saeed Mahameed
2023-12-05 6:13 ` [net V2 06/14] net/mlx5e: Tidy up IPsec NAT-T SA discovery Saeed Mahameed
2023-12-05 6:13 ` [net V2 07/14] net/mlx5e: Reduce eswitch mode_lock protection context Saeed Mahameed
2023-12-05 6:13 ` Saeed Mahameed [this message]
2023-12-08 4:47 ` [net V2 08/14] net/mlx5e: Check the number of elements before walk TC rhashtable Herbert Xu
2023-12-08 5:32 ` Jianbo Liu
2023-12-05 6:13 ` [net V2 09/14] net/mlx5e: Disable IPsec offload support if not FW steering Saeed Mahameed
2023-12-05 6:13 ` [net V2 10/14] net/mlx5e: Fix possible deadlock on mlx5e_tx_timeout_work Saeed Mahameed
2023-12-05 6:13 ` [net V2 11/14] net/mlx5e: TC, Don't offload post action rule if not supported Saeed Mahameed
2023-12-05 6:13 ` [net V2 12/14] net/mlx5: Nack sync reset request when HotPlug is enabled Saeed Mahameed
2023-12-05 6:13 ` [net V2 13/14] net/mlx5e: Check netdev pointer before checking its net ns Saeed Mahameed
2023-12-05 6:13 ` [net V2 14/14] net/mlx5: Fix a NULL vs IS_ERR() check Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205061327.44638-9-saeed@kernel.org \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jianbol@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).