From: Simon Horman <horms@kernel.org>
To: Min Li <lnimi@hotmail.com>
Cc: richardcochran@gmail.com, lee@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Min Li <min.li.xe@renesas.com>
Subject: Re: [PATCH net-next v6 1/6] ptp: clockmatrix: support 32-bit address space
Date: Tue, 5 Dec 2023 09:24:29 +0000 [thread overview]
Message-ID: <20231205092429.GS50400@kernel.org> (raw)
In-Reply-To: <PH7PR03MB70644CE21E835B48799F3EB3A082A@PH7PR03MB7064.namprd03.prod.outlook.com>
On Thu, Nov 30, 2023 at 01:46:29PM -0500, Min Li wrote:
> From: Min Li <min.li.xe@renesas.com>
>
> We used to assume 0x2010xxxx address. Now that
> we need to access 0x2011xxxx address, we need
> to support read/write the whole 32-bit address space.
>
> Signed-off-by: Min Li <min.li.xe@renesas.com>
...
> diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
> index f6f9d4adce04..f8556627befa 100644
> --- a/drivers/ptp/ptp_clockmatrix.c
> +++ b/drivers/ptp/ptp_clockmatrix.c
> @@ -41,8 +41,8 @@ module_param(firmware, charp, 0);
> static int _idtcm_adjfine(struct idtcm_channel *channel, long scaled_ppm);
>
> static inline int idtcm_read(struct idtcm *idtcm,
> - u16 module,
> - u16 regaddr,
> + u32 module,
> + u32 regaddr,
> u8 *buf,
> u16 count)
> {
> @@ -50,8 +50,8 @@ static inline int idtcm_read(struct idtcm *idtcm,
> }
>
> static inline int idtcm_write(struct idtcm *idtcm,
> - u16 module,
> - u16 regaddr,
> + u32 module,
> + u32 regaddr,
> u8 *buf,
> u16 count)
> {
Hi Min Li,
My understanding of Paolo's review of v5 was that it would be cleaner to:
1. Leave the type of the module parameter as u16
2. Update the type of the regaddr parameter to u32
And...
...
> @@ -553,11 +554,11 @@ static int _sync_pll_output(struct idtcm *idtcm,
> val = SYNCTRL1_MASTER_SYNC_RST;
>
> /* Place master sync in reset */
> - err = idtcm_write(idtcm, 0, sync_ctrl1, &val, sizeof(val));
> + err = idtcm_write(idtcm, sync_ctrl1, 0, &val, sizeof(val));
> if (err)
> return err;
>
> - err = idtcm_write(idtcm, 0, sync_ctrl0, &sync_src, sizeof(sync_src));
> + err = idtcm_write(idtcm, sync_ctrl0, 0, &sync_src, sizeof(sync_src));
> if (err)
> return err;
>
... avoid the need for changes like the two above.
As it is the meaning of module and regaddr are subtly reversed.
If that is intentional then it really ought to be at least stated
in the patch. And, IMHO, ideally a separate patch.
As it is, reversing the meaning of these parameters seems
to add extra churn to this patch.
next prev parent reply other threads:[~2023-12-05 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 18:46 [PATCH net-next v6 1/6] ptp: clockmatrix: support 32-bit address space Min Li
2023-12-05 9:06 ` Paolo Abeni
2023-12-05 9:24 ` Simon Horman [this message]
2023-12-05 9:28 ` Paolo Abeni
2023-12-06 16:29 ` Min Li
2023-12-07 11:10 ` Simon Horman
2023-12-13 21:04 ` Min Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205092429.GS50400@kernel.org \
--to=horms@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lnimi@hotmail.com \
--cc=min.li.xe@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).