From: Jakub Kicinski <kuba@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 5/8] dpaa2-switch: do not clear any interrupts automatically
Date: Tue, 5 Dec 2023 20:02:32 -0800 [thread overview]
Message-ID: <20231205200232.410387cc@kernel.org> (raw)
In-Reply-To: <20231204163528.1797565-6-ioana.ciornei@nxp.com>
On Mon, 4 Dec 2023 18:35:25 +0200 Ioana Ciornei wrote:
> The dpsw_get_irq_status() can clear interrupts automatically based on
> the value stored in the 'status' variable passed to it. We don't want
> that to happen because we could get into a situation when we are
> clearing more interrupts that we actually handled.
>
> Just resort to manually clearing interrupts after we received them using
> the dpsw_clear_irq_status().
Currently it can't cause any issues?
We won't get into an IRQ storm if some unexpected IRQ fires?
next prev parent reply other threads:[~2023-12-06 4:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 16:35 [PATCH 0/8] dpaa2-switch: small improvements Ioana Ciornei
2023-12-04 16:35 ` [PATCH 1/8] dpaa2-switch: set interface MAC address only on endpoint change Ioana Ciornei
2023-12-04 16:35 ` [PATCH 2/8] dpaa2-switch: declare the netdev as IFF_LIVE_ADDR_CHANGE capable Ioana Ciornei
2023-12-04 16:35 ` [PATCH 3/8] dpaa2-switch: print an error when the vlan is already configured Ioana Ciornei
2023-12-06 3:59 ` Jakub Kicinski
2023-12-12 12:24 ` Ioana Ciornei
2023-12-04 16:35 ` [PATCH 4/8] dpaa2-switch: add ENDPOINT_CHANGED to the irq_mask Ioana Ciornei
2023-12-06 3:58 ` Jakub Kicinski
2023-12-12 12:13 ` Ioana Ciornei
2023-12-04 16:35 ` [PATCH 5/8] dpaa2-switch: do not clear any interrupts automatically Ioana Ciornei
2023-12-06 4:02 ` Jakub Kicinski [this message]
2023-12-12 12:17 ` Ioana Ciornei
2023-12-04 16:35 ` [PATCH 6/8] dpaa2-switch: reorganize the [pre]changeupper events Ioana Ciornei
2023-12-04 16:35 ` [PATCH 7/8] dpaa2-switch: move a check to the prechangeupper stage Ioana Ciornei
2023-12-04 16:35 ` [PATCH 8/8] dpaa2-switch: cleanup the egress flood of an unused FDB Ioana Ciornei
2023-12-06 4:04 ` Jakub Kicinski
2023-12-12 12:09 ` Ioana Ciornei
2023-12-12 16:25 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205200232.410387cc@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).