From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <eadavis@qq.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>,
<syzbot+b5ad66046b913bc04c6f@syzkaller.appspotmail.com>,
<syzkaller-bugs@googlegroups.com>, <kuniyu@amazon.com>
Subject: Re: [PATCH] llc: fix uninit-value in __llc_lookup_established
Date: Wed, 6 Dec 2023 15:27:12 +0900 [thread overview]
Message-ID: <20231206062712.41467-1-kuniyu@amazon.com> (raw)
In-Reply-To: <tencent_269592755DA55D9B19384F870D9D25B18D07@qq.com>
From: Edward Adam Davis <eadavis@qq.com>
Date: Wed, 6 Dec 2023 09:55:15 +0800
> llc only supports ETH_P_802_2 protocol, so drop the skb when the protocol is
> not it.
This is not true. ETH_P_TR_802_2 is also processed by llc_rcv().
Let me post this formally.
https://lore.kernel.org/netdev/20231206005340.11534-1-kuniyu@amazon.com/
>
> Reported-by: syzbot+b5ad66046b913bc04c6f@syzkaller.appspotmail.com
> Signed-off-by: Edward Adam Davis <eadavis@qq.com>
> ---
> net/llc/llc_input.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/llc/llc_input.c b/net/llc/llc_input.c
> index 51bccfb00a9c..16b2c57f38c2 100644
> --- a/net/llc/llc_input.c
> +++ b/net/llc/llc_input.c
> @@ -141,7 +141,8 @@ static inline int llc_fixup_skb(struct sk_buff *skb)
> return 0;
> if (unlikely(pskb_trim_rcsum(skb, data_size)))
> return 0;
> - }
> + } else
> + return 0;
> return 1;
> }
>
> --
> 2.43.0
prev parent reply other threads:[~2023-12-06 6:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 18:25 [syzbot] [net?] KMSAN: uninit-value in __llc_lookup_established syzbot
2023-12-06 0:53 ` Kuniyuki Iwashima
2023-12-06 1:28 ` syzbot
2023-12-06 1:55 ` [PATCH] llc: fix " Edward Adam Davis
2023-12-06 6:27 ` Kuniyuki Iwashima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206062712.41467-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=eadavis@qq.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+b5ad66046b913bc04c6f@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).