From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <mkubecek@suse.cz>,
"Chittim, Madhu" <madhu.chittim@intel.com>,
"Samudrala, Sridhar" <sridhar.samudrala@intel.com>
Subject: Re: [RFC] ethtool: raw packet filtering
Date: Wed, 6 Dec 2023 08:16:05 -0800 [thread overview]
Message-ID: <20231206081605.0fad0f58@kernel.org> (raw)
In-Reply-To: <459ef75b-69dc-4baa-b7e4-6393b0b358ce@intel.com>
On Tue, 5 Dec 2023 11:23:34 -0700 Ahmed Zaki wrote:
> We are planning to send a patch series that enables raw packet filtering
> for ice and iavf. However, ethtool currently allows raw filtering on
> only 8 bytes via "user-def":
>
> # ethtool -N eth0 flow-type user-def N [m N] action N
>
>
> We are seeking the community's opinion on how to extend the ntuple
> interface to allow for up to 512 bytes of raw packet filtering. The
> direct approach is:
>
> # ethtool -N eth0 flow-type raw-fltr N [m N] action N
>
> where N would be allowed to be 512 bytes. Would that be acceptable? Any
> concerns regarding netlink or other user-space/kernel comm?
We need more info about the use case and what this will achieve.
Asking if you can extend uAPI is like asking if you can walk in
the street. Sometimes you can sometimes you can't. All depends
on context, so start with the context, please.
next prev parent reply other threads:[~2023-12-06 16:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 18:23 [RFC] ethtool: raw packet filtering Ahmed Zaki
2023-12-06 16:16 ` Jakub Kicinski [this message]
2023-12-06 22:47 ` Ahmed Zaki
2023-12-07 2:25 ` Jakub Kicinski
2023-12-11 23:34 ` Ahmed Zaki
2023-12-12 1:50 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206081605.0fad0f58@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=madhu.chittim@intel.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).