From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Johannes Berg <johannes.berg@intel.com>,
Marc MERLIN <marc@merlins.org>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH net v3] net: ethtool: do runtime PM outside RTNL
Date: Wed, 6 Dec 2023 08:44:48 -0800 [thread overview]
Message-ID: <20231206084448.53b48c49@kernel.org> (raw)
In-Reply-To: <20231206113934.8d7819857574.I2deb5804ef1739a2af307283d320ef7d82456494@changeid>
On Wed, 6 Dec 2023 11:39:32 +0100 Johannes Berg wrote:
> As reported by Marc MERLIN, at least one driver (igc) wants or
> needs to acquire the RTNL inside suspend/resume ops, which can
> be called from here in ethtool if runtime PM is enabled.
>
> Allow this by doing runtime PM transitions without the RTNL
> held. For the ioctl to have the same operations order, this
> required reworking the code to separately check validity and
> do the operation. For the netlink code, this now has to do
> the runtime_pm_put a bit later.
I was really, really hoping that this would serve as a motivation
for Intel to sort out the igb/igc implementation. The flow AFAICT
is ndo_open() starts the NIC, the calls pm_sus, which shuts the NIC
back down immediately (!?) then it schedules a link check from a work
queue, which opens it again (!?). It's a source of never ending bugs.
nit: please don't repost within 24h on netdev:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr
next prev parent reply other threads:[~2023-12-06 16:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 10:39 [PATCH net v3] net: ethtool: do runtime PM outside RTNL Johannes Berg
2023-12-06 16:44 ` Jakub Kicinski [this message]
2023-12-06 16:46 ` Johannes Berg
2023-12-06 21:39 ` Marc MERLIN
2023-12-07 10:16 ` Przemek Kitszel
2023-12-07 17:40 ` Jakub Kicinski
2023-12-11 4:52 ` Marc MERLIN
2023-12-15 13:42 ` Heiner Kallweit
2023-12-15 17:46 ` Marc MERLIN
2023-12-24 16:30 ` Marc MERLIN
2023-12-24 23:12 ` Heiner Kallweit
2023-12-25 8:03 ` [Intel-wired-lan] " Sasha Neftin
2023-12-25 11:21 ` Marc MERLIN
2024-01-03 10:30 ` Stanislaw Gruszka
2024-01-03 11:24 ` Heiner Kallweit
2024-01-03 12:15 ` Stanislaw Gruszka
2024-01-03 23:34 ` Jakub Kicinski
2024-01-04 8:25 ` Stanislaw Gruszka
2024-01-04 9:05 ` Heiner Kallweit
2024-01-04 16:16 ` Jakub Kicinski
2024-01-05 11:53 ` Stanislaw Gruszka
2024-01-05 15:30 ` Jakub Kicinski
2024-01-05 16:29 ` Stanislaw Gruszka
2024-01-06 3:02 ` Jakub Kicinski
2024-01-08 11:18 ` Stanislaw Gruszka
2024-01-05 10:34 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206084448.53b48c49@kernel.org \
--to=kuba@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=marc@merlins.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).