From: Jakub Kicinski <kuba@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
linux@armlinux.org.uk, andrew@lunn.ch, netdev@vger.kernel.org,
mengyuanlou@net-swift.com
Subject: Re: [PATCH net-next v3 4/7] net: wangxun: add ethtool_ops for ring parameters
Date: Wed, 6 Dec 2023 09:37:08 -0800 [thread overview]
Message-ID: <20231206093708.62f91a45@kernel.org> (raw)
In-Reply-To: <20231206095355.1220086-5-jiawenwu@trustnetic.com>
On Wed, 6 Dec 2023 17:53:52 +0800 Jiawen Wu wrote:
> + ngbe_down(wx);
> +
> + err = wx_set_ring(wx, new_tx_count, new_rx_count);
> +
> + wx_configure(wx);
> + ngbe_up(wx);
What if it fails? We don't allow down() / up() cycles on ethtool config
changes. You have to implement some form of reconfiguration, at minimum
it needs to be resilient to memory allocation failures (in which case
the old config should be kept and the device should keep running).
next prev parent reply other threads:[~2023-12-06 17:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 9:53 [PATCH net-next v3 0/7] Implement more ethtool_ops for Wangxun Jiawen Wu
2023-12-06 9:53 ` [PATCH net-next v3 1/7] net: ngbe: implement phylink to handle PHY device Jiawen Wu
2023-12-06 12:06 ` Russell King (Oracle)
2023-12-08 7:12 ` Jiawen Wu
2023-12-06 9:53 ` [PATCH net-next v3 2/7] net: wangxun: unified phylink implementation in libwx Jiawen Wu
2023-12-06 12:15 ` Russell King (Oracle)
2023-12-06 9:53 ` [PATCH net-next v3 3/7] net: wangxun: add flow control support Jiawen Wu
2023-12-06 9:53 ` [PATCH net-next v3 4/7] net: wangxun: add ethtool_ops for ring parameters Jiawen Wu
2023-12-06 17:37 ` Jakub Kicinski [this message]
2023-12-06 9:53 ` [PATCH net-next v3 5/7] net: wangxun: add coalesce options support Jiawen Wu
2023-12-06 9:53 ` [PATCH net-next v3 6/7] net: wangxun: add ethtool_ops for channel number Jiawen Wu
2023-12-06 17:35 ` Jakub Kicinski
2023-12-06 9:53 ` [PATCH net-next v3 7/7] net: wangxun: add ethtool_ops for msglevel Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206093708.62f91a45@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiawenwu@trustnetic.com \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).