From: Lee Jones <lee@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>,
Heiner Kallweit <hkallweit1@gmail.com>,
Christian Marangi <ansuelsmth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH v2] leds: trigger: netdev: fix RTNL handling to prevent potential deadlock
Date: Wed, 6 Dec 2023 13:32:34 +0000 [thread overview]
Message-ID: <20231206133234.GD3375667@google.com> (raw)
In-Reply-To: <20231204144808.26083e8a@kernel.org>
On Mon, 04 Dec 2023, Jakub Kicinski wrote:
> On Fri, 1 Dec 2023 11:23:22 +0100 Heiner Kallweit wrote:
> > When working on LED support for r8169 I got the following lockdep
> > warning. Easiest way to prevent this scenario seems to be to take
> > the RTNL lock before the trigger_data lock in set_device_name().
>
> Pavel/Lee, would you like to handle this patch?
> Or should we ship it to Linus on Thu?
Go for it.
Acked-by: Lee Jones <lee@kernel.org>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-12-06 13:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 10:23 [PATCH v2] leds: trigger: netdev: fix RTNL handling to prevent potential deadlock Heiner Kallweit
2023-12-01 21:57 ` Andrew Lunn
2023-12-04 22:48 ` Jakub Kicinski
2023-12-06 3:21 ` Jakub Kicinski
2023-12-06 13:32 ` Lee Jones [this message]
2023-12-06 16:19 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206133234.GD3375667@google.com \
--to=lee@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).