From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48E9870966; Wed, 6 Dec 2023 21:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="twVx/Shl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2283AC433C7; Wed, 6 Dec 2023 21:30:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701898238; bh=EOp+MGij0g64WAy1COWNmioZgirQtGqmKjfocQx8jHM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=twVx/ShlYhgK/Jw/IDceo1jDbIcb0cSb+M8yO5GcsOjsQ2kdr0g/GOYVkbqjRwkFx b/zG9FpZTmLkINbm5aoNb5RZELRSbA8ycJqWzBKFx9erYRhpvvK4trl9IgC/yzDayu 2XTlYYmi0PG7P9+Me8EYw7uP8hogrguvsmrEw1eMhitz4f+/w8ogmlUq1mAmSDvKvT xPPeaeZmPjnwUOFK6U3i+qqh8HByM2tjk8D+G8iel4kUaPHpyK+ys3tRNimAtxKdvv IsxXcwPffiAzdruSl4RNlAH4Pooq6lCxuG4RfsxZCNmRuxucM0p7Hv5LarOpTCi7U4 1yhzZ+pvwledg== Date: Wed, 6 Dec 2023 21:30:33 +0000 From: Simon Horman To: Shifeng Li Cc: Shifeng Li , saeedm@nvidia.com, leon@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ogerlitz@mellanox.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, dinghui@sangfor.com.cn Subject: Re: [PATCH] net/mlx5e: Fix slab-out-of-bounds in mlx5_query_nic_vport_mac_list() Message-ID: <20231206213033.GB50400@kernel.org> References: <20231130094656.894412-1-lishifeng@sangfor.com.cn> <20231203175015.GP50400@kernel.org> <35e833bf-8aa6-48bd-999c-6b4c9a4fe7f0@126.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35e833bf-8aa6-48bd-999c-6b4c9a4fe7f0@126.com> On Mon, Dec 04, 2023 at 10:30:14AM +0800, Shifeng Li wrote: > On 2023/12/4 1:50, Simon Horman wrote: > > On Thu, Nov 30, 2023 at 01:46:56AM -0800, Shifeng Li wrote: > > > Out_sz that the size of out buffer is calculated using query_nic_vport > > > _context_in structure when driver query the MAC list. However query_nic > > > _vport_context_in structure is smaller than query_nic_vport_context_out. > > > When allowed_list_size is greater than 96, calling ether_addr_copy() will > > > trigger an slab-out-of-bounds. > > > > > > [ 1170.055866] BUG: KASAN: slab-out-of-bounds in mlx5_query_nic_vport_mac_list+0x481/0x4d0 [mlx5_core] > > > [ 1170.055869] Read of size 4 at addr ffff88bdbc57d912 by task kworker/u128:1/461 > > > [ 1170.055870] > > > [ 1170.055932] Workqueue: mlx5_esw_wq esw_vport_change_handler [mlx5_core] > > > [ 1170.055936] Call Trace: > > > [ 1170.055949] dump_stack+0x8b/0xbb > > > [ 1170.055958] print_address_description+0x6a/0x270 > > > [ 1170.055961] kasan_report+0x179/0x2c0 > > > [ 1170.056061] mlx5_query_nic_vport_mac_list+0x481/0x4d0 [mlx5_core] > > > [ 1170.056162] esw_update_vport_addr_list+0x2c5/0xcd0 [mlx5_core] > > > [ 1170.056257] esw_vport_change_handle_locked+0xd08/0x1a20 [mlx5_core] > > > [ 1170.056377] esw_vport_change_handler+0x6b/0x90 [mlx5_core] > > > [ 1170.056381] process_one_work+0x65f/0x12d0 > > > [ 1170.056383] worker_thread+0x87/0xb50 > > > [ 1170.056390] kthread+0x2e9/0x3a0 > > > [ 1170.056394] ret_from_fork+0x1f/0x40 > > > > > > Fixes: e16aea2744ab ("net/mlx5: Introduce access functions to modify/query vport mac lists") > > > Cc: Ding Hui > > > Signed-off-by: Shifeng Li > > > > Hi, > > > > I am unsure how you calculated the 96 figure above. > > But in any case I agree that the cited patch introduced > > the mismatch that you describe. > > > out_sz = MLX5_ST_SZ_BYTES(query_nic_vport_context_in) + req_list_size * MLX5_ST_SZ_BYTES(mac_address_layout) > = 0x80/8 + 128 * 0x40/8 = 0x410 (bytes) > > nic_vport_ctx = MLX5_ADDR_OF(query_nic_vport_context_out, out, nic_vport_context) > = 0x880/8 = 0x110 (bytes) > mac_addr = MLX5_ADDR_OF(nic_vport_context, nic_vport_ctx, current_uc_mac_address[96]) + 2 > = 0x110 + 96 * 8 + 2 > = 0x412 (bytes) > > When i is 96, the mac_addr offset is 0x412 but the out_sz is 0x410. > And that will trigger an slab-out-of-bounds. Thanks for the clarification, this looks good to me. > > Reviewed-by: Simon Horman