From: Vladimir Oltean <olteanv@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Daniel Danzberger <dd@embedd.com>,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH] net: dsa: microchip: fix NULL pointer dereference on platform init
Date: Wed, 6 Dec 2023 23:49:28 +0200 [thread overview]
Message-ID: <20231206214928.jhx6naeo2o2eonj5@skbuf> (raw)
In-Reply-To: <19d4d689-a73e-4301-b22c-5ad2dfb4410d@lunn.ch>
On Wed, Dec 06, 2023 at 04:26:52PM +0100, Andrew Lunn wrote:
> > So, surprisingly, there is enough redundancy between DSA mechanisms that
> > platform_data kinda works.
>
> I have x86 platforms using mv88e6xxx with platform data. Simple
> systems do work, the platforms i have only make use of the internal
> PHYs. This is partially because of history. DSA is older than the
> adoption of DT. The mv88e6xxx driver and DSA used to be purely
> platform data driven, and we have not yet broken that.
>
> Andrew
I'm not saying that platform_data did not have its time and place, but
Device Tree clearly won, and platform_data is a rarely untested minority
nowadays.
We don't have to break platform_data in mv88e6xxx and in the DSA core
all of a sudden. It can coexist with software nodes for a while, as
alternative solutions to the same problem.
next prev parent reply other threads:[~2023-12-06 21:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 15:43 [PATCH] net: dsa: microchip: fix NULL pointer dereference on platform init Daniel Danzberger
2023-12-04 17:43 ` Vladimir Oltean
2023-12-05 8:00 ` Daniel Danzberger
2023-12-05 8:36 ` Vladimir Oltean
2023-12-05 9:08 ` Daniel Danzberger
2023-12-05 9:39 ` Vladimir Oltean
2023-12-05 16:55 ` Vladimir Oltean
2023-12-05 17:33 ` Daniel Danzberger
2023-12-05 18:17 ` Vladimir Oltean
2023-12-05 22:15 ` Daniel Danzberger
2023-12-06 0:37 ` Vladimir Oltean
2023-12-06 15:26 ` Andrew Lunn
2023-12-06 21:49 ` Vladimir Oltean [this message]
2023-12-05 10:12 ` Vladimir Oltean
2023-12-05 11:44 ` Daniel Danzberger
2023-12-05 12:04 ` Vladimir Oltean
2023-12-05 12:42 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206214928.jhx6naeo2o2eonj5@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=dd@embedd.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox