From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CE32481A7 for ; Thu, 7 Dec 2023 17:40:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R7SuUsyj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BBC5C433C8; Thu, 7 Dec 2023 17:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701970822; bh=3MgrRRErz3B11UzvKdbThDbzeiqoC9nl2Co0KiKHKTk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R7SuUsyjeYZVjUYjy9EFw2ib1iHEJTtYdMVmNH7f02ietc+AZGEaGmOPGeAVPM+Tp 7MuWLZ4NX0ohB6arsxCJdNEJUSN8/eRiLMyT7g7cge/9EbVcN/antkqLsGbQ+QQIu9 n+KPNeAjB2i3sywdMiiIjScvcyRS870eFGT56ixMUb5VoUu/vg5XSMKZE+rGNT/aX4 JQBc42daqQyGC+R+uirXAygB2P7tfyNaoyuS2rYiOdyvzYCggYFL4dWYzaxlzTWfP4 ECAzlY3wHQrcnbfueTWGKjy9kHgG2RhpJfoV75VchpnlF/s1va2iYVyTKIOVjt0oyg oxTOGyE93WayQ== Date: Thu, 7 Dec 2023 09:40:21 -0800 From: Jakub Kicinski To: Przemek Kitszel Cc: Johannes Berg , , Heiner Kallweit , "Marc MERLIN" , "intel-wired-lan@lists.osuosl.org" Subject: Re: [PATCH net v3] net: ethtool: do runtime PM outside RTNL Message-ID: <20231207094021.1419b5d0@kernel.org> In-Reply-To: References: <20231206113934.8d7819857574.I2deb5804ef1739a2af307283d320ef7d82456494@changeid> <20231206084448.53b48c49@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 7 Dec 2023 11:16:10 +0100 Przemek Kitszel wrote: > I have let know our igc TL, architect, and anybody that could be > interested via cc: IWL. And I'm happy that this could be done at > relaxed pace thanks to Johannes I think you may be expecting us to take Johannes's patch. It's still on the table, but to make things clear - upstream we prefer to wait for the "real fix", so if we agree that fixing igb/igc is a better way (as Heiner pointed out on previous version PM functions are called by the stack under rtnl elsewhere too, just not while device is open) - we'll wait for that. Especially that I'm 80% I complained about the PM in those drivers in the past and nobody seemed to care. It's a constant source of rtnl deadlocks.