* [PATCH net] net: wangxun: fix changing mac failed when running
@ 2023-12-06 9:50 duanqiangwen
2023-12-07 18:05 ` Jakub Kicinski
2023-12-07 18:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: duanqiangwen @ 2023-12-06 9:50 UTC (permalink / raw)
To: netdev, kuba, mengyuanlou, jiawenwu, davem, andrew, bhelgaas,
maciej.fijalkowski
Cc: duanqiangwen
in some bonding mode, service need to change mac when
netif is running. Wangxun netdev add IFF_LIVE_ADDR_CHANGE
priv_flag to support it.
Fixes: 79625f45ca73 ("net: wangxun: Move MAC address handling to libwx")
Signed-off-by: duanqiangwen <duanqiangwen@net-swift.com>
---
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 1 +
drivers/net/ethernet/wangxun/txgbe/txgbe_main.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
index 8db804543e66..a5c623fd023e 100644
--- a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
+++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
@@ -582,6 +582,7 @@ static int ngbe_probe(struct pci_dev *pdev,
netdev->priv_flags |= IFF_UNICAST_FLT;
netdev->priv_flags |= IFF_SUPP_NOFCS;
+ netdev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
netdev->min_mtu = ETH_MIN_MTU;
netdev->max_mtu = WX_MAX_JUMBO_FRAME_SIZE -
diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
index 526250102db2..a78da2309db5 100644
--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
+++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
@@ -638,6 +638,7 @@ static int txgbe_probe(struct pci_dev *pdev,
netdev->priv_flags |= IFF_UNICAST_FLT;
netdev->priv_flags |= IFF_SUPP_NOFCS;
+ netdev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
netdev->min_mtu = ETH_MIN_MTU;
netdev->max_mtu = WX_MAX_JUMBO_FRAME_SIZE -
--
2.12.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: wangxun: fix changing mac failed when running
2023-12-06 9:50 [PATCH net] net: wangxun: fix changing mac failed when running duanqiangwen
@ 2023-12-07 18:05 ` Jakub Kicinski
2023-12-07 18:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2023-12-07 18:05 UTC (permalink / raw)
To: duanqiangwen
Cc: netdev, mengyuanlou, jiawenwu, davem, andrew, bhelgaas,
maciej.fijalkowski
On Wed, 6 Dec 2023 17:50:44 +0800 duanqiangwen wrote:
> in some bonding mode, service need to change mac when
> netif is running. Wangxun netdev add IFF_LIVE_ADDR_CHANGE
> priv_flag to support it.
>
> Fixes: 79625f45ca73 ("net: wangxun: Move MAC address handling to libwx")
>
> Signed-off-by: duanqiangwen <duanqiangwen@net-swift.com>
Enabling something is not a fix, sorry :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: wangxun: fix changing mac failed when running
2023-12-06 9:50 [PATCH net] net: wangxun: fix changing mac failed when running duanqiangwen
2023-12-07 18:05 ` Jakub Kicinski
@ 2023-12-07 18:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-12-07 18:10 UTC (permalink / raw)
To: duanqiangwen
Cc: netdev, kuba, mengyuanlou, jiawenwu, davem, andrew, bhelgaas,
maciej.fijalkowski
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 6 Dec 2023 17:50:44 +0800 you wrote:
> in some bonding mode, service need to change mac when
> netif is running. Wangxun netdev add IFF_LIVE_ADDR_CHANGE
> priv_flag to support it.
>
> Fixes: 79625f45ca73 ("net: wangxun: Move MAC address handling to libwx")
>
> Signed-off-by: duanqiangwen <duanqiangwen@net-swift.com>
>
> [...]
Here is the summary with links:
- [net] net: wangxun: fix changing mac failed when running
https://git.kernel.org/netdev/net-next/c/87e839c82cc3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-07 18:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-06 9:50 [PATCH net] net: wangxun: fix changing mac failed when running duanqiangwen
2023-12-07 18:05 ` Jakub Kicinski
2023-12-07 18:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).