From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 922641400F for ; Thu, 7 Dec 2023 18:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VaQB/1QQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0D14C433C7; Thu, 7 Dec 2023 18:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701972341; bh=1rHnRo1OxdwPdjBcECC27VCHGCyW8gdU2nJP9R/mPpk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VaQB/1QQtlH3X5JWQu5Wjh9B4+qcmIC5eAtKaSteSgszABQZM4t8fYxAEEPNVXEag pJqTtoWM6GQypqO8T/4C5fWhdbwXjv4Uwf0x5M/EYm9A2dah8fkZzrsflEdYEQP4PO gO4jKv+u6sMUiZF12kXWsCx6xLP3MRv+H4OspacSMre+g7GnPuEzMFI2TIE8g5A4A0 VVednt0rfRNoP/9zuGfhCdo9dXWpqcoohKkOBZ455Fi5jVtQm6KEQArx+FbKqwd+kK qThpvyo64JvTZAgPsoO8QARI/YN/neeUpZsE7Syc+mN+9eyKPmqAwr7dt0IWkv8ICO W5UncTTZ+QHdA== Date: Thu, 7 Dec 2023 10:05:39 -0800 From: Jakub Kicinski To: duanqiangwen Cc: netdev@vger.kernel.org, mengyuanlou@net-swift.com, jiawenwu@trustnetic.com, davem@davemloft.net, andrew@lunn.ch, bhelgaas@google.com, maciej.fijalkowski@intel.com Subject: Re: [PATCH net] net: wangxun: fix changing mac failed when running Message-ID: <20231207100539.210efc63@kernel.org> In-Reply-To: <20231206095044.17844-1-duanqiangwen@net-swift.com> References: <20231206095044.17844-1-duanqiangwen@net-swift.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 6 Dec 2023 17:50:44 +0800 duanqiangwen wrote: > in some bonding mode, service need to change mac when > netif is running. Wangxun netdev add IFF_LIVE_ADDR_CHANGE > priv_flag to support it. > > Fixes: 79625f45ca73 ("net: wangxun: Move MAC address handling to libwx") > > Signed-off-by: duanqiangwen Enabling something is not a fix, sorry :(