From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, gospo@broadcom.com,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
Vikas Gupta <vikas.gupta@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>
Subject: Re: [PATCH net v2 3/4] bnxt_en: Fix wrong return value check in bnxt_close_nic()
Date: Thu, 7 Dec 2023 10:27:18 -0800 [thread overview]
Message-ID: <20231207102718.4d930353@kernel.org> (raw)
In-Reply-To: <20231207000551.138584-4-michael.chan@broadcom.com>
On Wed, 6 Dec 2023 16:05:50 -0800 Michael Chan wrote:
> The wait_event_interruptible_timeout() function returns 0
> if the timeout elapsed, -ERESTARTSYS if it was interrupted
> by a signal, and the remaining jiffies otherwise if the
> condition evaluated to true before the timeout elapsed.
>
> Driver should have checked for zero return value instead of
> a positive value.
Not sure how this was not caught earlier, maybe there is a more
complicated story behind it. Otherwise you should handle -ERESTARTSYS
as well.
next prev parent reply other threads:[~2023-12-07 18:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 0:05 [PATCH net v2 0/4] bnxt_en: Misc. fixes Michael Chan
2023-12-07 0:05 ` [PATCH net v2 1/4] bnxt_en: Clear resource reservation during resume Michael Chan
2023-12-07 18:20 ` Jakub Kicinski
2023-12-07 0:05 ` [PATCH net v2 2/4] bnxt_en: Fix skb recycling logic in bnxt_deliver_skb() Michael Chan
2023-12-07 18:21 ` Jakub Kicinski
2023-12-07 18:22 ` Jakub Kicinski
2023-12-07 18:37 ` Andy Gospodarek
2023-12-07 18:41 ` Jakub Kicinski
2023-12-07 0:05 ` [PATCH net v2 3/4] bnxt_en: Fix wrong return value check in bnxt_close_nic() Michael Chan
2023-12-07 18:27 ` Jakub Kicinski [this message]
2023-12-07 22:24 ` Michael Chan
2023-12-07 22:31 ` Jakub Kicinski
2023-12-07 0:05 ` [PATCH net v2 4/4] bnxt_en: Fix HWTSTAMP_FILTER_ALL packet timestamp logic Michael Chan
2023-12-07 12:04 ` [PATCH net v2 0/4] bnxt_en: Misc. fixes Vadim Fedorenko
2023-12-07 16:24 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207102718.4d930353@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=somnath.kotur@broadcom.com \
--cc=vikas.gupta@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).