From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 282D734543 for ; Thu, 7 Dec 2023 11:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bRv8qsUp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0252FC433C8; Thu, 7 Dec 2023 11:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701947459; bh=1GE+mf0M0KnVzSbveKgDHZnYMGMtfQATU7YdiEcjdfQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bRv8qsUpzi+wV0FVGR8+L44XLGzNXSCy3PGcMV7xweY5xGCb/yVLS3xllREgouT8T 4wt+pnZE0VgOD10Kngj3iBE6nME4nm6VA3HugFaGaE8BAP8DYlf+Vwh609MukT9+/a mW/LEHznaNltz20leHIsoDuMI622H94T47KsVowwIcXBgdwjhkKLOh5pHRj1x56spG bsJiBnprBudNvERMua54waX5hs7RNnlM+DhDZV5grSUv9h5rwDwilXhwLBFnQ7vzVF X/2vsuJbzT1sKTL9Y9oa/BxhTYM3IQ8C6soWrH4PsuIymYQ8vdsPAvaul6E0ozYx/D l73Azfkst1uBA== Date: Thu, 7 Dec 2023 11:10:55 +0000 From: Simon Horman To: Min Li Cc: Paolo Abeni , Min Li , "richardcochran@gmail.com" , "lee@kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next v6 1/6] ptp: clockmatrix: support 32-bit address space Message-ID: <20231207111055.GF50400@kernel.org> References: <20231205092429.GS50400@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Dec 06, 2023 at 04:29:09PM +0000, Min Li wrote: > > > > > > Hi Min Li, > > > > > > My understanding of Paolo's review of v5 was that it would be cleaner to: > > > > > > 1. Leave the type of the module parameter as u16 2. Update the type of > > > the regaddr parameter to u32 > > > > [almost over the air conflict here ;) ] > > > > I think the module parameter as u32 is needed, as later macro definitions > > will leverage that. Yes, sorry. I got things muddled up there. > > > And... > > > > > > ... avoid the need for changes like the two above. > > > > This part is correct/what I meant ;) > > > > Hi Paolo/Simon > > Thanks for your reviews. Ideally, I would want to maintain regaddr as u16 since for clockmatrix addressing, it is only the lower 8bit of the whole 32bit address while module is upper 24bit. On the other hand, for some simple cases, where only one register in a module, their addresses are defined by module only without regaddr such as sync_ctrl0/1 > > Overall, I still want to differentiate between module and regaddr and don't wanna mix them up. My reading is that this patch reverses the usage of module and regaddr. F.e. the following hunk: @@ -553,11 +554,11 @@ static int _sync_pll_output(struct idtcm *idtcm, val = SYNCTRL1_MASTER_SYNC_RST; /* Place master sync in reset */ err = idtcm_write(idtcm, 0, sync_ctrl1, &val, sizeof(val)); err = idtcm_write(idtcm, sync_ctrl1, 0, &val, sizeof(val)); if (err) return err; err = idtcm_write(idtcm, 0, sync_ctrl0, &sync_src, sizeof(sync_src)); err = idtcm_write(idtcm, sync_ctrl0, 0, &sync_src, sizeof(sync_src)); if (err) return err; If that is really intended I think it needs to be explained, or possibly a separate patch.