From: Christian Marangi <ansuelsmth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Christian Marangi <ansuelsmth@gmail.com>
Subject: [net-next PATCH v4 01/13] net: phy: at803x: fix passing the wrong reference for config_intr
Date: Fri, 8 Dec 2023 15:51:48 +0100 [thread overview]
Message-ID: <20231208145200.25162-2-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20231208145200.25162-1-ansuelsmth@gmail.com>
Fix passing the wrong reference for config_initr on passing the function
pointer, drop the wrong & from at803x_config_intr in the PHY struct.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/phy/at803x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 37fb033e1c29..ef203b0807e5 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -2104,7 +2104,7 @@ static struct phy_driver at803x_driver[] = {
.write_page = at803x_write_page,
.get_features = at803x_get_features,
.read_status = at803x_read_status,
- .config_intr = &at803x_config_intr,
+ .config_intr = at803x_config_intr,
.handle_interrupt = at803x_handle_interrupt,
.get_tunable = at803x_get_tunable,
.set_tunable = at803x_set_tunable,
@@ -2134,7 +2134,7 @@ static struct phy_driver at803x_driver[] = {
.resume = at803x_resume,
.flags = PHY_POLL_CABLE_TEST,
/* PHY_BASIC_FEATURES */
- .config_intr = &at803x_config_intr,
+ .config_intr = at803x_config_intr,
.handle_interrupt = at803x_handle_interrupt,
.cable_test_start = at803x_cable_test_start,
.cable_test_get_status = at803x_cable_test_get_status,
@@ -2150,7 +2150,7 @@ static struct phy_driver at803x_driver[] = {
.resume = at803x_resume,
.flags = PHY_POLL_CABLE_TEST,
/* PHY_BASIC_FEATURES */
- .config_intr = &at803x_config_intr,
+ .config_intr = at803x_config_intr,
.handle_interrupt = at803x_handle_interrupt,
.cable_test_start = at803x_cable_test_start,
.cable_test_get_status = at803x_cable_test_get_status,
--
2.40.1
next prev parent reply other threads:[~2023-12-08 14:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 14:51 [net-next PATCH v4 00/13] net: phy: at803x: cleanup Christian Marangi
2023-12-08 14:51 ` Christian Marangi [this message]
2023-12-08 14:51 ` [net-next PATCH v4 02/13] net: phy: at803x: move disable WOL to specific at8031 probe Christian Marangi
2023-12-08 14:51 ` [net-next PATCH v4 03/13] net: phy: at803x: raname hw_stats functions to qca83xx specific name Christian Marangi
2023-12-08 14:51 ` [net-next PATCH v4 04/13] net: phy: at803x: move qca83xx specific check in dedicated functions Christian Marangi
2023-12-08 14:51 ` [net-next PATCH v4 05/13] net: phy: at803x: move specific DT option for at8031 to specific probe Christian Marangi
2023-12-08 14:51 ` [net-next PATCH v4 06/13] net: phy: at803x: move specific at8031 probe mode check to dedicated probe Christian Marangi
2023-12-08 14:51 ` [net-next PATCH v4 07/13] net: phy: at803x: move specific at8031 config_init to dedicated function Christian Marangi
2023-12-08 14:51 ` [net-next PATCH v4 08/13] net: phy: at803x: move specific at8031 WOL bits " Christian Marangi
2023-12-08 14:51 ` [net-next PATCH v4 09/13] net: phy: at803x: move specific at8031 config_intr " Christian Marangi
2023-12-08 14:51 ` [net-next PATCH v4 10/13] net: phy: at803x: make at8031 related DT functions name more specific Christian Marangi
2023-12-08 14:51 ` [net-next PATCH v4 11/13] net: phy: at803x: move at8031 functions in dedicated section Christian Marangi
2023-12-08 14:51 ` [net-next PATCH v4 12/13] net: phy: at803x: move at8035 specific DT parse to dedicated probe Christian Marangi
2023-12-08 14:52 ` [net-next PATCH v4 13/13] net: phy: at803x: drop specific PHY ID check from cable test functions Christian Marangi
2023-12-13 10:40 ` [net-next PATCH v4 00/13] net: phy: at803x: cleanup patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208145200.25162-2-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).