[PATCH net-next] i40e: remove fake support of rx-frames-irq

[PATCH net-next] i40e: remove fake support of rx-frames-irq

[Tony Nguyen]

From: Jason Xing <kernelxing@tencent.com>

Since we never support this feature for I40E driver, we don't have to
display the value when using 'ethtool -c eth0'.

Before this patch applied, the rx-frames-irq is 256 which is consistent
with tx-frames-irq. Apparently it could mislead users.

Signed-off-by: Jason Xing <kernelxing@tencent.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index eb9a7b32af73..2a0a12a79aa3 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -2895,7 +2895,6 @@ static int __i40e_get_coalesce(struct net_device *netdev,
 	struct i40e_vsi *vsi = np->vsi;
 
 	ec->tx_max_coalesced_frames_irq = vsi->work_limit;
-	ec->rx_max_coalesced_frames_irq = vsi->work_limit;
 
 	/* rx and tx usecs has per queue value. If user doesn't specify the
 	 * queue, return queue 0's value to represent.
@@ -3029,7 +3028,7 @@ static int __i40e_set_coalesce(struct net_device *netdev,
 	struct i40e_pf *pf = vsi->back;
 	int i;
 
-	if (ec->tx_max_coalesced_frames_irq || ec->rx_max_coalesced_frames_irq)
+	if (ec->tx_max_coalesced_frames_irq)
 		vsi->work_limit = ec->tx_max_coalesced_frames_irq;
 
 	if (queue < 0) {
-- 
2.41.0

Re: [PATCH net-next] i40e: remove fake support of rx-frames-irq

[Jakub Kicinski]

On Thu,  7 Dec 2023 10:36:47 -0800 Tony Nguyen wrote:
> From: Jason Xing <kernelxing@tencent.com>
> 
> Since we never support this feature for I40E driver, we don't have to
> display the value when using 'ethtool -c eth0'.
> 
> Before this patch applied, the rx-frames-irq is 256 which is consistent
> with tx-frames-irq. Apparently it could mislead users.

IIUC now the rx-frames-irq will be 0 / not set, so you should also:

diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index a0b10230268d..611996a35943 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -5786,7 +5786,7 @@ static const struct ethtool_ops i40e_ethtool_recovery_mode_ops = {
 
 static const struct ethtool_ops i40e_ethtool_ops = {
 	.supported_coalesce_params = ETHTOOL_COALESCE_USECS |
-				     ETHTOOL_COALESCE_MAX_FRAMES_IRQ |
+				     ETHTOOL_COALESCE_TX_MAX_FRAMES_IRQ |
 				     ETHTOOL_COALESCE_USE_ADAPTIVE |
 				     ETHTOOL_COALESCE_RX_USECS_HIGH |
 				     ETHTOOL_COALESCE_TX_USECS_HIGH,
-- 
pw-bot: cr

Re: [PATCH net-next] i40e: remove fake support of rx-frames-irq

[Jason Xing]

On Sat, Dec 9, 2023 at 9:20 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu,  7 Dec 2023 10:36:47 -0800 Tony Nguyen wrote:
> > From: Jason Xing <kernelxing@tencent.com>
> >
> > Since we never support this feature for I40E driver, we don't have to
> > display the value when using 'ethtool -c eth0'.
> >
> > Before this patch applied, the rx-frames-irq is 256 which is consistent
> > with tx-frames-irq. Apparently it could mislead users.
>
[...]
> IIUC now the rx-frames-irq will be 0 / not set, so you should also:
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> index a0b10230268d..611996a35943 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> @@ -5786,7 +5786,7 @@ static const struct ethtool_ops i40e_ethtool_recovery_mode_ops = {
>
>  static const struct ethtool_ops i40e_ethtool_ops = {
>         .supported_coalesce_params = ETHTOOL_COALESCE_USECS |
> -                                    ETHTOOL_COALESCE_MAX_FRAMES_IRQ |
> +                                    ETHTOOL_COALESCE_TX_MAX_FRAMES_IRQ |
>                                      ETHTOOL_COALESCE_USE_ADAPTIVE |
>                                      ETHTOOL_COALESCE_RX_USECS_HIGH |
>                                      ETHTOOL_COALESCE_TX_USECS_HIGH,
> --

Thanks for the review, I will add this part into my V2 patch.

Jason

> pw-bot: cr
>