From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.merlins.org (magic.merlins.org [209.81.13.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18B71ED for ; Sun, 10 Dec 2023 20:52:10 -0800 (PST) Received: from c-76-132-34-178.hsd1.ca.comcast.net ([76.132.34.178]:58984 helo=sauron.svh.merlins.org) by mail1.merlins.org with esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2 #2) id 1rCYGv-0004Vc-9r by authid with srv_auth_plain; Sun, 10 Dec 2023 20:52:01 -0800 Received: from merlin by sauron.svh.merlins.org with local (Exim 4.92) (envelope-from ) id 1rCYGu-000roj-Sl; Sun, 10 Dec 2023 20:52:00 -0800 Date: Sun, 10 Dec 2023 20:52:00 -0800 From: Marc MERLIN To: Jakub Kicinski Cc: Przemek Kitszel , Johannes Berg , netdev@vger.kernel.org, Heiner Kallweit , "intel-wired-lan@lists.osuosl.org" Subject: Re: [PATCH net v3] net: ethtool: do runtime PM outside RTNL Message-ID: <20231211045200.GC24475@merlins.org> References: <20231206113934.8d7819857574.I2deb5804ef1739a2af307283d320ef7d82456494@changeid> <20231206084448.53b48c49@kernel.org> <20231207094021.1419b5d0@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231207094021.1419b5d0@kernel.org> X-Sysadmin: BOFH X-URL: http://marc.merlins.org/ X-SA-Exim-Connect-IP: 76.132.34.178 X-SA-Exim-Mail-From: marc@merlins.org On Thu, Dec 07, 2023 at 09:40:21AM -0800, Jakub Kicinski wrote: > On Thu, 7 Dec 2023 11:16:10 +0100 Przemek Kitszel wrote: > > I have let know our igc TL, architect, and anybody that could be > > interested via cc: IWL. And I'm happy that this could be done at > > relaxed pace thanks to Johannes > > I think you may be expecting us to take Johannes's patch. > It's still on the table, but to make things clear - > upstream we prefer to wait for the "real fix", so if we agree > that fixing igb/igc is a better way (as Heiner pointed out on previous > version PM functions are called by the stack under rtnl elsewhere too, > just not while device is open) - we'll wait for that. Especially > that I'm 80% I complained about the PM in those drivers in > the past and nobody seemed to care. It's a constant source of rtnl > deadlocks. For whatever it's worth, I want to be clear that all stock kernels are 100% unusable on lenovo P17gen2 because of this deadlock and that without the temporary patch, my laptop would be usuable. It was also a risk of data loss due to repeated deadlocks and unclean shutdowns. I cannot say what the correct fix is, but I am definitely hoping you will accept some solution for the next stable kernel. Thank you Marc -- "A mouse is a device used to point at the xterm you want to type in" - A.S.R. Home page: http://marc.merlins.org/ | PGP 7F55D5F27AAF9D08