From: Jakub Kicinski <kuba@kernel.org>
To: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>, <jacob.e.keller@intel.com>,
<vaishnavi.tipireddy@intel.com>, <horms@kernel.org>,
<leon@kernel.org>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
Subject: Re: [PATCH net-next v5 2/5] ice: configure FW logging
Date: Mon, 11 Dec 2023 08:30:00 -0800 [thread overview]
Message-ID: <20231211083000.350bd5e4@kernel.org> (raw)
In-Reply-To: <df263bfa-9610-419b-8b17-623f5fb54d26@intel.com>
On Sat, 9 Dec 2023 16:09:40 -0800 Paul M Stillwell Jr wrote:
> This brings up the question of whether I should use seq_printf() for all
> the other _read fucntions. It feels like a lot of extra code to do it
> for the other _read functions because they output so little info and we
> control the output so it seems to be overkill to use seq_printf() for
> those. What do you think?
My rule of thumb would be to use seq_printf() if you have to allocate
a buffer on the heap for the output. If you can output directly to user
space or the output is small enough to fit in an on-stack buffer - no
need for seq_printf(). But YMMV.
next prev parent reply other threads:[~2023-12-11 16:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 21:12 [PATCH net-next v5 0/5][pull request] add v2 FW logging for ice driver Tony Nguyen
2023-12-05 21:12 ` [PATCH net-next v5 1/5] ice: remove FW logging code Tony Nguyen
2023-12-05 21:12 ` [PATCH net-next v5 2/5] ice: configure FW logging Tony Nguyen
2023-12-07 3:53 ` Jakub Kicinski
2023-12-08 0:28 ` Paul M Stillwell Jr
2023-12-08 2:19 ` Jakub Kicinski
2023-12-10 0:09 ` Paul M Stillwell Jr
2023-12-11 16:30 ` Jakub Kicinski [this message]
2023-12-11 17:04 ` Paul M Stillwell Jr
2023-12-05 21:12 ` [PATCH net-next v5 3/5] ice: enable " Tony Nguyen
2023-12-05 21:12 ` [PATCH net-next v5 4/5] ice: add ability to read and configure FW log data Tony Nguyen
2023-12-05 21:12 ` [PATCH net-next v5 5/5] ice: add documentation for FW logging Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211083000.350bd5e4@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.m.stillwell.jr@intel.com \
--cc=vaishnavi.tipireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).