From: Jakub Kicinski <kuba@kernel.org>
To: Patrick Williams <patrick@stwcx.xyz>
Cc: Ivan Mikhaylov <fr0st61te@gmail.com>,
davem@davemloft.net, edumazet@google.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, peter@pjd.dev, sam@mendozajonas.com
Subject: Re: [PATCH net-next v2 3/3] net/ncsi: Add NC-SI 1.2 Get MC MAC Address command
Date: Mon, 11 Dec 2023 08:51:39 -0800 [thread overview]
Message-ID: <20231211085139.011f650a@kernel.org> (raw)
In-Reply-To: <ZXZ5EOSJAekCiT44@heinlein.vulture-banana.ts.net>
On Sun, 10 Dec 2023 20:50:56 -0600 Patrick Williams wrote:
> Either you or I can send a "Fixes: " on this commit to improve the
> handling as you're proposing. While the change is likely trivial, I
> have not had any chance to test it yet, so I've not sent it up myself.
> If you want to refactor the code to reduce duplication, I think that should
> be an entirely separate proposal.
Yes, incremental change is better.
next prev parent reply other threads:[~2023-12-11 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 16:07 [PATCH net-next v2 0/3] net/ncsi: Add NC-SI 1.2 Get MC MAC Address command Patrick Williams
2023-11-14 16:07 ` [PATCH net-next v2 1/3] net/ncsi: Simplify Kconfig/dts control flow Patrick Williams
2023-11-14 16:07 ` [PATCH net-next v2 2/3] net/ncsi: Fix netlink major/minor version numbers Patrick Williams
2023-11-14 16:07 ` [PATCH net-next v2 3/3] net/ncsi: Add NC-SI 1.2 Get MC MAC Address command Patrick Williams
2023-12-10 21:53 ` Ivan Mikhaylov
2023-12-11 2:50 ` Patrick Williams
2023-12-11 16:51 ` Jakub Kicinski [this message]
2023-11-18 15:10 ` [PATCH net-next v2 0/3] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211085139.011f650a@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fr0st61te@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patrick@stwcx.xyz \
--cc=peter@pjd.dev \
--cc=sam@mendozajonas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).