From: Jakub Kicinski <kuba@kernel.org>
To: Victor Nogueira <victor@mojatatu.com>
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
daniel@iogearbox.net, dcaratti@redhat.com,
netdev@vger.kernel.org, kernel@mojatatu.com
Subject: Re: [PATCH net-next v3 3/3] net: sched: Add initial TC error skb drop reasons
Date: Mon, 11 Dec 2023 18:30:31 -0800 [thread overview]
Message-ID: <20231211183031.78f6ffa6@kernel.org> (raw)
In-Reply-To: <20231205205030.3119672-4-victor@mojatatu.com>
On Tue, 5 Dec 2023 17:50:30 -0300 Victor Nogueira wrote:
> + /**
> + * @SKB_DROP_REASON_TC_EXT_COOKIE_NOTFOUND: tc cookie was looked up
> + * using ext, but was not found.
> + */
> + SKB_DROP_REASON_TC_EXT_COOKIE_NOTFOUND,
> + /**
> + * @SKB_DROP_REASON_TC_COOKIE_EXT_MISMATCH: tc ext was lookup using
> + * cookie and either was not found or different from expected.
> + */
> + SKB_DROP_REASON_TC_COOKIE_EXT_MISMATCH,
> + /**
> + * @SKB_DROP_REASON_TC_COOKIE_MISMATCH: tc cookie available but was
> + * unable to match to filter.
> + */
> + SKB_DROP_REASON_TC_COOKIE_MISMATCH,
Do we really need 3 reasons for COOKIE?
Also cookie here is offload state thing right? I wonder how many admins
/ SREs would be able to figure out what's going on based on this kdoc :S
Let alone if it's a configuration problem or a race condition...
next prev parent reply other threads:[~2023-12-12 2:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 20:50 [PATCH net-next v3 0/3] net: sched: Make tc-related drop reason more flexible for remaining qdiscs Victor Nogueira
2023-12-05 20:50 ` [PATCH net-next v3 1/3] net: sched: Move drop_reason to struct tc_skb_cb Victor Nogueira
2023-12-05 21:17 ` Daniel Borkmann
2023-12-11 13:37 ` Simon Horman
2023-12-05 20:50 ` [PATCH net-next v3 2/3] net: sched: Make tc-related drop reason more flexible for remaining qdiscs Victor Nogueira
2023-12-05 21:20 ` Daniel Borkmann
2023-12-11 13:38 ` Simon Horman
2023-12-12 2:25 ` Jakub Kicinski
2023-12-12 16:27 ` Jamal Hadi Salim
2023-12-12 16:57 ` Eric Dumazet
2023-12-12 17:16 ` Jamal Hadi Salim
2023-12-13 18:36 ` Jamal Hadi Salim
2023-12-13 21:08 ` Jakub Kicinski
2023-12-14 15:31 ` Jamal Hadi Salim
2023-12-14 17:18 ` Taehee Yoo
2023-12-15 14:42 ` Jamal Hadi Salim
2023-12-14 18:01 ` Jakub Kicinski
2023-12-05 20:50 ` [PATCH net-next v3 3/3] net: sched: Add initial TC error skb drop reasons Victor Nogueira
2023-12-11 13:38 ` Simon Horman
2023-12-12 2:30 ` Jakub Kicinski [this message]
2023-12-13 18:25 ` Victor Nogueira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211183031.78f6ffa6@kernel.org \
--to=kuba@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=victor@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).