From: Jakub Kicinski <kuba@kernel.org>
To: Louis Peens <louis.peens@corigine.com>
Cc: David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Hui Zhou <hui.zhou@corigine.com>,
netdev@vger.kernel.org, stable@vger.kernel.org,
oss-drivers@corigine.com
Subject: Re: [PATCH net 2/2] nfp: flower: fix hardware offload for the transfer layer port
Date: Mon, 11 Dec 2023 19:08:49 -0800 [thread overview]
Message-ID: <20231211190849.6c7d5246@kernel.org> (raw)
In-Reply-To: <20231208065956.11917-3-louis.peens@corigine.com>
On Fri, 8 Dec 2023 08:59:56 +0200 Louis Peens wrote:
> + if (mangle_action->mangle.offset == offsetof(struct tcphdr, source)) {
> + mangle_action->mangle.val =
> + (__force u32)cpu_to_be32(mangle_action->mangle.val << 16);
> + mangle_action->mangle.mask =
> + (__force u32)cpu_to_be32(mangle_action->mangle.mask << 16 | 0xFFFF);
This a bit odd. Here you fill in the "other half" of the mask with Fs...
> + }
> + if (mangle_action->mangle.offset == offsetof(struct tcphdr, dest)) {
> + mangle_action->mangle.offset = 0;
> + mangle_action->mangle.val =
> + (__force u32)cpu_to_be32(mangle_action->mangle.val);
> + mangle_action->mangle.mask =
> + (__force u32)cpu_to_be32(mangle_action->mangle.mask);
> + }
.. but here you just let it be zero.
If it's correct it'd be good to explain in the commit msg why.
--
pw-bot: cr
next prev parent reply other threads:[~2023-12-12 3:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 6:59 [PATCH net 0/2] nfp: flower: a few small conntrack offload fixes Louis Peens
2023-12-08 6:59 ` [PATCH net 1/2] nfp: flower: add hardware offload check for post ct entry Louis Peens
2023-12-08 6:59 ` [PATCH net 2/2] nfp: flower: fix hardware offload for the transfer layer port Louis Peens
2023-12-12 3:08 ` Jakub Kicinski [this message]
2023-12-12 15:09 ` Louis Peens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211190849.6c7d5246@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=hui.zhou@corigine.com \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).