From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E6FA51C37 for ; Mon, 11 Dec 2023 19:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pJQ8f+4z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E439C433C7; Mon, 11 Dec 2023 19:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702322745; bh=5PCDJcoJLtnGpRV0DAjYRK8BuRBZFwRiLOSsdq1VC4k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pJQ8f+4zwstIOdI5SABdp1eyca+2SHXI3CYUyYwelTY7g+FxxA6gq8iEZaJJaIqYe 0ZsFUxruMDzia2FJIXsEMGYiIqMrgDWu8JxCdf5+5nnE4Bvm77/WwoR9CuBn6/SQi/ uqEWP2j1JC0NqER8BRvclRgLvHuTGp2NjIey2OphPKieEB4+HA72uKqEW1f6Dx09P4 fypwV+lT3Zb5oyOJJYWBLO3kvpzFDSHu+RSoXXCcogkAsM4MmUSkmjd1tscyplcPIk vRe/R41pRDbGWhyO8bV7m0hdTOrus/HCZR7OlYMiK6j7XsZ5beNRBHJk2nShLN7ZUh PNt06r1IF77fQ== Date: Mon, 11 Dec 2023 19:25:40 +0000 From: Simon Horman To: edward.cree@amd.com Cc: linux-net-drivers@amd.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, Edward Cree , netdev@vger.kernel.org, habetsm.xilinx@gmail.com, Jonathan Cooper Subject: Re: [PATCH net-next 6/7] sfc: add debugfs entries for filter table status Message-ID: <20231211192540.GR5817@kernel.org> References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Dec 11, 2023 at 05:18:31PM +0000, edward.cree@amd.com wrote: > From: Edward Cree > > Filter table management is complicated by the possibility of overflow > kicking us into a promiscuous fallback for either unicast or multicast. > Expose the internal flags that drive this. > Since the table state (efx->filter_state) has a separate, shorter > lifetime than struct efx_nic, put its debugfs nodes in a subdirectory > (efx->filter_state->debug_dir) so that they can be cleaned up easily > before the filter_state is freed. > > Reviewed-by: Jonathan Cooper > Signed-off-by: Edward Cree ... > index 4ff6586116ee..a4ab45082c8f 100644 > --- a/drivers/net/ethernet/sfc/mcdi_filters.c > +++ b/drivers/net/ethernet/sfc/mcdi_filters.c > @@ -1348,6 +1348,20 @@ int efx_mcdi_filter_table_probe(struct efx_nic *efx, bool multicast_chaining) > INIT_LIST_HEAD(&table->vlan_list); > init_rwsem(&table->lock); > > +#ifdef CONFIG_DEBUG_FS > + table->debug_dir = debugfs_create_dir("filters", efx->debug_dir); > + debugfs_create_bool("uc_promisc", 0444, table->debug_dir, > + &table->uc_promisc); > + debugfs_create_bool("mc_promisc", 0444, table->debug_dir, > + &table->mc_promisc); > + debugfs_create_bool("mc_promisc_last", 0444, table->debug_dir, > + &table->mc_promisc_last); > + debugfs_create_bool("mc_overflow", 0444, table->debug_dir, > + &table->mc_overflow); > + debugfs_create_bool("mc_chaining", 0444, table->debug_dir, > + &table->mc_chaining); > +#endif > + > efx->filter_state = table; > > return 0; > @@ -1518,6 +1532,10 @@ void efx_mcdi_filter_table_remove(struct efx_nic *efx) > return; > > vfree(table->entry); > +#ifdef CONFIG_DEBUG_FS > + /* Remove debugfs entries pointing into @table */ > + debugfs_remove_recursive(table->debug_dir); > +#endif > kfree(table); > } > Hi Edward, I think debugfs.h needs to be included so that debugfs_*() are defined. ... -- pw-bot: changes-requested