From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TZw7s9GB" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14B5FDB for ; Tue, 12 Dec 2023 07:54:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702396498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=txHf+m37wKb+jlfgEujM/pT7BGBPXZR98p4Uri23mF0=; b=TZw7s9GB6rRkmFZIrZyBvvsIi+Fu6OSardRgd/GXQleBnSSg85PcKk2n9eFnjtYtHnU2KX XZNOZwhfe+VUN37o/L8//HqNZBUdwsrDsaivRX/hs96Wuny8QrqhogXDDYK7qnTl4gr3Ls MgFjuw1p8lfrufZZDCjr1cLa9lK8HDI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-461-ZY90hsq1PTeZldxLWIhLpg-1; Tue, 12 Dec 2023 10:54:56 -0500 X-MC-Unique: ZY90hsq1PTeZldxLWIhLpg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3334286b720so5072187f8f.1 for ; Tue, 12 Dec 2023 07:54:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702396495; x=1703001295; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=txHf+m37wKb+jlfgEujM/pT7BGBPXZR98p4Uri23mF0=; b=DILJmrBhjNI1jGCj6M9b7BNL1VQl5Iy/gF/6WqzEpTf+UqVJ9x6ELByIjLqKZe5S8o MdsjPlDz5N67lw2QdPHIvsBNfkKN96ozUXhXrGH7btHiMzBIodyyK91xjUkbyUVwq1cP e7Rp1fZbk/q5dEWPloO/0m3392gofrH4eQMjLzLvS6caFoOekKO3V1T4tfCfuZY0mptf X+C7xUEzw9ZTIlAvf3QE0Hl8wkena7X4eewlh/dZdEtlL6zZ1EIx8/t7JW6rFz5cqeNL PGG7lZt7oE6qWI1fr6KVhmJDdNpmsHWUqiX+0YvEYdLap1WFnivOg7WsGb8vO0TdwyMw X3pw== X-Gm-Message-State: AOJu0YyG6wWQQrngwrRK3dGQKiAZdKtkQUg3tV+pLq7wU4ZehgKv68Wf 7lt/hR7K+cP6lLPdHq8NvnYYVKdv/mdX/Ier+KUO8jvpgqF00QN8Oi8EikK9LZSs1RfJxEJ76Vn lD0vfbEfhy60Ypqcp X-Received: by 2002:a05:600c:231a:b0:40c:25ab:d6fc with SMTP id 26-20020a05600c231a00b0040c25abd6fcmr1447486wmo.216.1702396495532; Tue, 12 Dec 2023 07:54:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IE6GXeZSyM1qg+LLJdrpeJbqwQTw5tjPpZngQ1PCsTrEqzrWUOeqVfj9G+x5Joo7Xk9NkQ1tg== X-Received: by 2002:a05:600c:231a:b0:40c:25ab:d6fc with SMTP id 26-20020a05600c231a00b0040c25abd6fcmr1447475wmo.216.1702396495084; Tue, 12 Dec 2023 07:54:55 -0800 (PST) Received: from redhat.com ([2.52.23.105]) by smtp.gmail.com with ESMTPSA id h11-20020adffd4b000000b003333298eb4bsm11227676wrs.61.2023.12.12.07.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 07:54:54 -0800 (PST) Date: Tue, 12 Dec 2023 10:54:50 -0500 From: "Michael S. Tsirkin" To: Arseniy Krasnov Cc: Stefan Hajnoczi , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jason Wang , Bobby Eshleman , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@sberdevices.ru, oxffffaa@gmail.com Subject: Re: [PATCH net-next v8 0/4] send credit update during setting SO_RCVLOWAT Message-ID: <20231212105423-mutt-send-email-mst@kernel.org> References: <20231211211658.2904268-1-avkrasnov@salutedevices.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231211211658.2904268-1-avkrasnov@salutedevices.com> On Tue, Dec 12, 2023 at 12:16:54AM +0300, Arseniy Krasnov wrote: > Hello, > > DESCRIPTION > > This patchset fixes old problem with hungup of both rx/tx sides and adds > test for it. This happens due to non-default SO_RCVLOWAT value and > deferred credit update in virtio/vsock. Link to previous old patchset: > https://lore.kernel.org/netdev/39b2e9fd-601b-189d-39a9-914e5574524c@sberdevices.ru/ Patchset: Acked-by: Michael S. Tsirkin But I worry whether we actually need 3/8 in net not in net-next. Thanks! > Here is what happens step by step: > > TEST > > INITIAL CONDITIONS > > 1) Vsock buffer size is 128KB. > 2) Maximum packet size is also 64KB as defined in header (yes it is > hardcoded, just to remind about that value). > 3) SO_RCVLOWAT is default, e.g. 1 byte. > > > STEPS > > SENDER RECEIVER > 1) sends 128KB + 1 byte in a > single buffer. 128KB will > be sent, but for 1 byte > sender will wait for free > space at peer. Sender goes > to sleep. > > > 2) reads 64KB, credit update not sent > 3) sets SO_RCVLOWAT to 64KB + 1 > 4) poll() -> wait forever, there is > only 64KB available to read. > > So in step 4) receiver also goes to sleep, waiting for enough data or > connection shutdown message from the sender. Idea to fix it is that rx > kicks tx side to continue transmission (and may be close connection) > when rx changes number of bytes to be woken up (e.g. SO_RCVLOWAT) and > this value is bigger than number of available bytes to read. > > I've added small test for this, but not sure as it uses hardcoded value > for maximum packet length, this value is defined in kernel header and > used to control deferred credit update. And as this is not available to > userspace, I can't control test parameters correctly (if one day this > define will be changed - test may become useless). > > Head for this patchset is: > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=021b0c952f226236f2edf89c737efb9a28d1422d > > Link to v1: > https://lore.kernel.org/netdev/20231108072004.1045669-1-avkrasnov@salutedevices.com/ > Link to v2: > https://lore.kernel.org/netdev/20231119204922.2251912-1-avkrasnov@salutedevices.com/ > Link to v3: > https://lore.kernel.org/netdev/20231122180510.2297075-1-avkrasnov@salutedevices.com/ > Link to v4: > https://lore.kernel.org/netdev/20231129212519.2938875-1-avkrasnov@salutedevices.com/ > Link to v5: > https://lore.kernel.org/netdev/20231130130840.253733-1-avkrasnov@salutedevices.com/ > Link to v6: > https://lore.kernel.org/netdev/20231205064806.2851305-1-avkrasnov@salutedevices.com/ > Link to v7: > https://lore.kernel.org/netdev/20231206211849.2707151-1-avkrasnov@salutedevices.com/ > > Changelog: > v1 -> v2: > * Patchset rebased and tested on new HEAD of net-next (see hash above). > * New patch is added as 0001 - it removes return from SO_RCVLOWAT set > callback in 'af_vsock.c' when transport callback is set - with that > we can set 'sk_rcvlowat' only once in 'af_vsock.c' and in future do > not copy-paste it to every transport. It was discussed in v1. > * See per-patch changelog after ---. > v2 -> v3: > * See changelog after --- in 0003 only (0001 and 0002 still same). > v3 -> v4: > * Patchset rebased and tested on new HEAD of net-next (see hash above). > * See per-patch changelog after ---. > v4 -> v5: > * Change patchset tag 'RFC' -> 'net-next'. > * See per-patch changelog after ---. > v5 -> v6: > * New patch 0003 which sends credit update during reading bytes from > socket. > * See per-patch changelog after ---. > v6 -> v7: > * Patchset rebased and tested on new HEAD of net-next (see hash above). > * See per-patch changelog after ---. > v7 -> v8: > * See per-patch changelog after ---. > > Arseniy Krasnov (4): > vsock: update SO_RCVLOWAT setting callback > virtio/vsock: send credit update during setting SO_RCVLOWAT > virtio/vsock: fix logic which reduces credit update messages > vsock/test: two tests to check credit update logic > > drivers/vhost/vsock.c | 1 + > include/linux/virtio_vsock.h | 1 + > include/net/af_vsock.h | 2 +- > net/vmw_vsock/af_vsock.c | 9 +- > net/vmw_vsock/hyperv_transport.c | 4 +- > net/vmw_vsock/virtio_transport.c | 1 + > net/vmw_vsock/virtio_transport_common.c | 43 +++++- > net/vmw_vsock/vsock_loopback.c | 1 + > tools/testing/vsock/vsock_test.c | 175 ++++++++++++++++++++++++ > 9 files changed, 229 insertions(+), 8 deletions(-) > > -- > 2.25.1