From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Stefan Eichenberger <eichest@gmail.com>
Cc: mw@semihalf.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: mvpp2: add support for mii
Date: Tue, 12 Dec 2023 17:07:04 +0100 [thread overview]
Message-ID: <20231212170704.74565969@device.home> (raw)
In-Reply-To: <20231212141200.62579-1-eichest@gmail.com>
Hi Stefan,
On Tue, 12 Dec 2023 15:12:00 +0100
Stefan Eichenberger <eichest@gmail.com> wrote:
> Currently, mvpp2 only supports RGMII. This commit adds support for MII.
> The description in Marvell's functional specification seems to be wrong.
> To enable MII, we need to set GENCONF_CTRL0_PORT3_RGMII, while for RGMII
> we need to clear it. This is also how U-Boot handles it.
>
> Signed-off-by: Stefan Eichenberger <eichest@gmail.com>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Thanks for the patch,
Maxime
next prev parent reply other threads:[~2023-12-12 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 14:12 [PATCH net-next v2] net: mvpp2: add support for mii Stefan Eichenberger
2023-12-12 16:07 ` Maxime Chevallier [this message]
2023-12-12 17:39 ` Marcin Wojtas
2023-12-12 19:19 ` Russell King (Oracle)
2023-12-14 15:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212170704.74565969@device.home \
--to=maxime.chevallier@bootlin.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eichest@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).