From: Simon Horman <horms@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: netdev@vger.kernel.org, kernel test robot <lkp@intel.com>,
Gregory Greenman <gregory.greenman@intel.com>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
linux-wireless@vger.kernel.org, Kalle Valo <kvalo@kernel.org>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] wifi: iwlwifi: fw/dbg: fix all kernel-doc warnings
Date: Tue, 12 Dec 2023 19:24:52 +0000 [thread overview]
Message-ID: <20231212192452.GD5817@kernel.org> (raw)
In-Reply-To: <20231208220945.20628-1-rdunlap@infradead.org>
On Fri, Dec 08, 2023 at 02:09:45PM -0800, Randy Dunlap wrote:
> kernel test robot reports:
> drivers/net/wireless/intel/iwlwifi/fw/dbg.c:86: warning: Excess struct/union/enum/typedef member 'trans_len' description in 'iwl_fw_dump_ptrs'
>
> scripts/kernel-doc no longer emits the warning that is reported by
> the 0-day kernel test robot, but the reported struct does contain the
> Excess line, so remove that line as well as fix other kernel-doc
> warnings in this source file:
>
> dbg.c:1732: warning: contents before sections
> dbg.c:1736: warning: No description found for return value of 'mask_apply_and_normalize'
> dbg.c:2202: warning: missing initial short description on line:
> * iwl_dump_ini_mem
> dbg.c:2207: warning: contents before sections
> dbg.c:2215: warning: No description found for return value of 'iwl_dump_ini_mem'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311250305.tf8Cus1Y-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202312060810.QT9zourt-lkp@intel.com/
> Cc: Gregory Greenman <gregory.greenman@intel.com>
> Cc: Miri Korenblit <miriam.rachel.korenblit@intel.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: Kalle Valo <kvalo@kernel.org>
> Cc: Johannes Berg <johannes@sipsolutions.net>
Thanks Randy,
I'm unable to reproduce the "other warnings".
But these changes do look good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
...
prev parent reply other threads:[~2023-12-12 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 22:09 [PATCH] wifi: iwlwifi: fw/dbg: fix all kernel-doc warnings Randy Dunlap
2023-12-12 19:24 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212192452.GD5817@kernel.org \
--to=horms@kernel.org \
--cc=gregory.greenman@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=miriam.rachel.korenblit@intel.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).