From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6DF02030D; Wed, 13 Dec 2023 09:46:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tB5OQxh/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88F15C433C7; Wed, 13 Dec 2023 09:46:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702460812; bh=k3h+x5Vi0c4IUc2BgiJewMzJeCYyvSk8+ZHJK/SWAOw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tB5OQxh//OBSfXK0FUdFSzcfEoIJyEniRxaI6FF3p7iKPcZ+k+7oHa13+VC5BtTVW AIvVDladP54+eKEj0Gizw4euRRRU6KZCljmIlisdNUIFEIPMh59eypu8BxdaDEnvgg +J1/VytncX+iPP7xylS4qbsFfaeCyc35ucSWlT1PIR9VG8UK+IadGA4rhnRd1kZdNI /xMEdLMTt+iCLnF06HyS5MK4EQ/RO1rWc5rGrvf97MSFIVP3+KQmnXpVVESH+jjOa7 Y3XgFLpzUW+W4LKrAmsIIn5S1Y6lJPRrOn80Znicol+dSEaP5p+knty92G1xUrhR47 j9Ggn0ti7Ij1A== Date: Wed, 13 Dec 2023 09:46:44 +0000 From: Conor Dooley To: Daniel Golle Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Andrew Lunn , Heiner Kallweit , Russell King , Alexander Couzens , Qingfang Deng , SkyLake Huang , Philipp Zabel , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org Subject: Re: [RFC PATCH net-next v3 1/8] dt-bindings: phy: mediatek,xfi-pextp: add new bindings Message-ID: <20231213-confined-shaping-f56b1fdfb135@spud> References: <20231212-renderer-strobe-2b46652cd6e7@spud> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TQLtrFVr4ShS8Ew7" Content-Disposition: inline In-Reply-To: --TQLtrFVr4ShS8Ew7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 12, 2023 at 04:42:45PM +0000, Daniel Golle wrote: > On Tue, Dec 12, 2023 at 04:21:38PM +0000, Conor Dooley wrote: > > On Tue, Dec 12, 2023 at 03:46:26AM +0000, Daniel Golle wrote: > >=20 > > > + mediatek,usxgmii-performance-errata: > > > + $ref: /schemas/types.yaml#/definitions/flag > > > + description: > > > + USXGMII0 on MT7988 suffers from a performance problem in 10GBa= se-R > > > + mode which needs a work-around in the driver. The work-around = is > > > + enabled using this flag. > >=20 > > Why do you need a property for this if you know that it is present on > > the MT7988? >=20 > Because it is only present in one of the two SerDes channels. > Channel 0 needs the work-around, Channel 1 doesn't. >=20 > See also this commit in the vendor driver for reference[1]. >=20 > We previously discussed that[2] and it was decided that a property > would be the prefered way to represent this as there aren't any other > per-instance differences which would justify another compatible. Please put it in the commit message so that when the next version shows up, Krzysztof doesn't show up and question the property for the third time. Also, on another note, this series is aimed at net-next but half the series is fixed for incorrect bindings. Why not net? --TQLtrFVr4ShS8Ew7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZXl9hAAKCRB4tDGHoIJi 0l51AP9AfxTVJus53lwalnfKdDDM6fu9GnfTQ1DaU51hYEgGlAD+KJiVYUIfbVyH NeYoGDoBXFZkUEImGzZ7OfYXmDAzTQw= =+6BB -----END PGP SIGNATURE----- --TQLtrFVr4ShS8Ew7--