From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6D99642 for ; Thu, 14 Dec 2023 02:21:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i0Nt4gWA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04A1BC433C7; Thu, 14 Dec 2023 02:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702520472; bh=E+nTFsxPhhLeQMpDCEQGk2uiEZkW2LcAQEEFfBZAtG4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=i0Nt4gWAGZ0loOUiz3/ecoZACsJrcTxv3P0A3aLSPYDX7Ha7JW854C/nDDgJZPkeV uTGo7DeG00edeKD/n1LvuiKCLOUPA3HyqmdBrEA4pQKNkKTYV/wEnCr9Clma/6NeWU utlfaVdB13m/Y6BWnjzPSpn5kYuIR6jq5Jo4QgHvI7HVOlgPCigMp1bDKyZA0IOeQy g2VHWgHzdb9sqE2OcPoHsRLOYoHTxsMJrZ9wjtAaaDfLjxhoB8lk4SmenGr/SX3y6o 5GP05crTcpWYall8bnQkNS3X9Ug72EC1vFXdJ/wtTs+idHPD96FM3DGNaYp1wmCKmK 2lsEnDOTk1RwQ== Date: Wed, 13 Dec 2023 18:21:10 -0800 From: Jakub Kicinski To: duanqiangwen Cc: netdev@vger.kernel.org, jiawenwu@trustnetic.com, mengyuanlou@net-swift.com, davem@davemloft.net, pabeni@redhat.com, yang.lee@linux.alibaba.com, shaozhengchao@huawei.com, horms@kernel.org Subject: Re: [PATCH net v3] net: libwx: fix memory leak on free page Message-ID: <20231213182110.38052c7b@kernel.org> In-Reply-To: <20231212032902.23180-1-duanqiangwen@net-swift.com> References: <20231212032902.23180-1-duanqiangwen@net-swift.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 12 Dec 2023 11:29:02 +0800 duanqiangwen wrote: > - __page_frag_cache_drain(rx_buffer->page, > - rx_buffer->pagecnt_bias); > + > sorry for the late nit pick, there's a double new line here checkpatch seems to miss this :S > i++;