From: Simon Horman <horms@kernel.org>
To: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, Jacob Keller <jacob.e.keller@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-next v4 2/2] ixgbe: Refactor returning internal error codes
Date: Thu, 14 Dec 2023 09:56:42 +0000 [thread overview]
Message-ID: <20231214095642.GK5817@kernel.org> (raw)
In-Reply-To: <20231212104642.316887-3-jedrzej.jagielski@intel.com>
On Tue, Dec 12, 2023 at 11:46:42AM +0100, Jedrzej Jagielski wrote:
> Change returning codes to the kernel ones instead of
> the internal ones for the entire ixgbe driver.
>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> ---
> v3: do not use ENOSYS; rebase
> ---
> .../net/ethernet/intel/ixgbe/ixgbe_82598.c | 36 ++---
> .../net/ethernet/intel/ixgbe/ixgbe_82599.c | 61 ++++----
> .../net/ethernet/intel/ixgbe/ixgbe_common.c | 145 ++++++++----------
> .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 2 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 26 ++--
> drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.c | 34 ++--
> drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 1 -
> drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 84 +++++-----
> .../net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 39 -----
> drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 44 +++---
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 109 ++++++-------
> 12 files changed, 266 insertions(+), 317 deletions(-)
Thanks Jedrzej,
this is a nice cleanup.
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2023-12-14 9:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 10:46 [PATCH iwl-next v4 0/2] ixgbe: Refactor ixgbe internal status Jedrzej Jagielski
2023-12-12 10:46 ` [PATCH iwl-next v4 1/2] ixgbe: Refactor overtemp event handling Jedrzej Jagielski
2023-12-13 9:20 ` Przemek Kitszel
2023-12-14 9:55 ` Simon Horman
2023-12-14 13:37 ` Jagielski, Jedrzej
2023-12-17 9:38 ` Simon Horman
2023-12-12 10:46 ` [PATCH iwl-next v4 2/2] ixgbe: Refactor returning internal error codes Jedrzej Jagielski
2023-12-14 9:56 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214095642.GK5817@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jedrzej.jagielski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).