From: Jakub Kicinski <kuba@kernel.org>
To: Aurelien Aptel <aaptel@nvidia.com>
Cc: linux-nvme@lists.infradead.org, netdev@vger.kernel.org,
sagi@grimberg.me, hch@lst.de, kbusch@kernel.org, axboe@fb.com,
chaitanyak@nvidia.com, davem@davemloft.net,
aurelien.aptel@gmail.com, smalin@nvidia.com, malin1024@gmail.com,
ogerlitz@nvidia.com, yorayz@nvidia.com, borisp@nvidia.com,
galshalom@nvidia.com, mgurtovoy@nvidia.com, edumazet@google.com,
pabeni@redhat.com, john.fastabend@gmail.com,
daniel@iogearbox.net
Subject: Re: [PATCH v21 04/20] net/tls,core: export get_netdev_for_sock
Date: Thu, 14 Dec 2023 18:11:28 -0800 [thread overview]
Message-ID: <20231214181128.63793cdc@kernel.org> (raw)
In-Reply-To: <20231214132623.119227-5-aaptel@nvidia.com>
On Thu, 14 Dec 2023 13:26:07 +0000 Aurelien Aptel wrote:
> -struct net_device *netdev_sk_get_lowest_dev(struct net_device *dev,
> - struct sock *sk)
> +struct net_device *get_netdev_for_sock(struct sock *sk)
> {
> - struct net_device *lower;
> + struct dst_entry *dst = sk_dst_get(sk);
> + struct net_device *dev, *lower;
>
> - lower = netdev_sk_get_lower_dev(dev, sk);
> - while (lower) {
> + if (unlikely(!dst))
> + return NULL;
> + dev = dst->dev;
> + while ((lower = netdev_sk_get_lower_dev(dev, sk)))
> dev = lower;
> - lower = netdev_sk_get_lower_dev(dev, sk);
> - }
> -
> + dev_hold(dev);
> + dst_release(dst);
> return dev;
> }
> -EXPORT_SYMBOL(netdev_sk_get_lowest_dev);
> +EXPORT_SYMBOL_GPL(get_netdev_for_sock);
Since the use of this helper is now spreading we should
switch it to netdev_hold and have the caller pass in a
netdevice_tracker.
next prev parent reply other threads:[~2023-12-15 2:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 13:26 [PATCH v21 00/20] nvme-tcp receive offloads Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 01/20] net: Introduce direct data placement tcp offload Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 02/20] netlink: add new family to manage ULP_DDP enablement and stats Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 03/20] iov_iter: skip copy if src == dst for direct data placement Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 04/20] net/tls,core: export get_netdev_for_sock Aurelien Aptel
2023-12-15 2:11 ` Jakub Kicinski [this message]
2023-12-15 13:46 ` Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 05/20] nvme-tcp: Add DDP offload control path Aurelien Aptel
2023-12-17 0:18 ` Max Gurtovoy
2023-12-18 20:00 ` Aurelien Aptel
2023-12-20 11:30 ` Max Gurtovoy
2023-12-14 13:26 ` [PATCH v21 06/20] nvme-tcp: Add DDP data-path Aurelien Aptel
2023-12-17 17:06 ` Max Gurtovoy
2023-12-18 18:08 ` Aurelien Aptel
2023-12-18 18:47 ` Max Gurtovoy
2023-12-14 13:26 ` [PATCH v21 07/20] nvme-tcp: RX DDGST offload Aurelien Aptel
2023-12-20 13:35 ` Max Gurtovoy
2023-12-14 13:26 ` [PATCH v21 08/20] nvme-tcp: Deal with netdevice DOWN events Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 09/20] Documentation: add ULP DDP offload documentation Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 10/20] net/mlx5e: Rename from tls to transport static params Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 11/20] net/mlx5e: Refactor ico sq polling to get budget Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 12/20] net/mlx5: Add NVMEoTCP caps, HW bits, 128B CQE and enumerations Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 13/20] net/mlx5e: NVMEoTCP, offload initialization Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 14/20] net/mlx5e: TCP flow steering for nvme-tcp acceleration Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 15/20] net/mlx5e: NVMEoTCP, use KLM UMRs for buffer registration Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 16/20] net/mlx5e: NVMEoTCP, queue init/teardown Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 17/20] net/mlx5e: NVMEoTCP, ddp setup and resync Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 18/20] net/mlx5e: NVMEoTCP, async ddp invalidation Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 19/20] net/mlx5e: NVMEoTCP, data-path for DDP+DDGST offload Aurelien Aptel
2023-12-14 13:26 ` [PATCH v21 20/20] net/mlx5e: NVMEoTCP, statistics Aurelien Aptel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214181128.63793cdc@kernel.org \
--to=kuba@kernel.org \
--cc=aaptel@nvidia.com \
--cc=aurelien.aptel@gmail.com \
--cc=axboe@fb.com \
--cc=borisp@nvidia.com \
--cc=chaitanyak@nvidia.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=galshalom@nvidia.com \
--cc=hch@lst.de \
--cc=john.fastabend@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=malin1024@gmail.com \
--cc=mgurtovoy@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@nvidia.com \
--cc=pabeni@redhat.com \
--cc=sagi@grimberg.me \
--cc=smalin@nvidia.com \
--cc=yorayz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).