From: Jakub Kicinski <kuba@kernel.org>
To: Victor Nogueira <victor@mojatatu.com>
Cc: jhs@mojatatu.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
mleitner@redhat.com, vladbu@nvidia.com, paulb@nvidia.com,
pctammela@mojatatu.com, netdev@vger.kernel.org,
kernel@mojatatu.com
Subject: Re: [PATCH net-next v6 3/3] net/sched: act_mirred: Allow mirred to block
Date: Thu, 14 Dec 2023 19:09:19 -0800 [thread overview]
Message-ID: <20231214190919.2b446e31@kernel.org> (raw)
In-Reply-To: <20231214141006.3578080-4-victor@mojatatu.com>
On Thu, 14 Dec 2023 11:10:06 -0300 Victor Nogueira wrote:
> So far the mirred action has dealt with syntax that handles mirror/redirection for netdev.
> A matching packet is redirected or mirrored to a target netdev.
>
> In this patch we enable mirred to mirror to a tc block as well.
> IOW, the new syntax looks as follows:
> ... mirred <ingress | egress> <mirror | redirect> [index INDEX] < <blockid BLOCKID> | <dev <devname>> >
>
> Examples of mirroring or redirecting to a tc block:
> $ tc filter add block 22 protocol ip pref 25 \
> flower dst_ip 192.168.0.0/16 action mirred egress mirror blockid 22
>
> $ tc filter add block 22 protocol ip pref 25 \
> flower dst_ip 10.10.10.10/32 action mirred egress redirect blockid 22
net/sched/act_mirred.c:424:6: warning: variable 'err' set but not used [-Wunused-but-set-variable]
424 | int err = 0;
| ^
--
pw-bot: cr
next prev parent reply other threads:[~2023-12-15 3:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 14:10 [PATCH net-next v6 0/3] net/sched: Introduce tc block ports tracking and use Victor Nogueira
2023-12-14 14:10 ` [PATCH net-next v6 1/3] net/sched: Introduce tc block netdev tracking infra Victor Nogueira
2023-12-14 14:10 ` [PATCH net-next v6 2/3] net/sched: cls_api: Expose tc block to the datapath Victor Nogueira
2023-12-14 14:10 ` [PATCH net-next v6 3/3] net/sched: act_mirred: Allow mirred to block Victor Nogueira
2023-12-15 3:09 ` Jakub Kicinski [this message]
2023-12-15 11:12 ` Victor Nogueira
2023-12-14 14:29 ` [PATCH net-next v6 0/3] net/sched: Introduce tc block ports tracking and use Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214190919.2b446e31@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulb@nvidia.com \
--cc=pctammela@mojatatu.com \
--cc=victor@mojatatu.com \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).