From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0044518AF9; Fri, 15 Dec 2023 09:59:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="anZH1k01" Received: by mail.gandi.net (Postfix) with ESMTPSA id 06B82240004; Fri, 15 Dec 2023 09:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1702634372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yExJ2o/kc8OLXIlEOTC2J4B49akJNkoaJGJOI+Bu0FI=; b=anZH1k01slCSYKb4V1xZMlexTsV75XZ5Aka0I6oA6yhuAq38LsOora95YD8h0Stu6dgxxN 1hHFB1NUUAkctIBJ1r7ufRMIfsnAVMoJcUIMTNw4QQN5bVSTamR+BZH+rNsZY7hDmVsbfo cPTnLkRcJQS0LeeYKDDU3UH+6gS6dDGIItYCJGd8greNpvep2cUyI3LxSNM+yR7dDqHpnO I06jXnrzEmr5Rum39s6+z1V02ZU1J0vapuAtnwFASq4IcbVCPz5qufSgWoqWho24aPM3Of l0CH0XnFfo8awZNH9fTI6c8KTSjsjqEX5he9TMpKELzNdTlbQ3lg0k/5OtQ4hw== Date: Fri, 15 Dec 2023 10:59:28 +0100 From: Maxime Chevallier To: Andrew Lunn Cc: "Russell King (Oracle)" , Paolo Abeni , Daniel Golle , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: phy: skip LED triggers on PHYs on SFP modules Message-ID: <20231215105928.74608001@device-28.home> In-Reply-To: <37a66b85-3980-4553-8447-d040404bbc11@lunn.ch> References: <102a9dce38bdf00215735d04cd4704458273ad9c.1702339354.git.daniel@makrotopia.org> <20231212153512.67a7a35b@device.home> <6dd8d8b62d6db979d6c2197a4091ebc768e6610a.camel@redhat.com> <37a66b85-3980-4553-8447-d040404bbc11@lunn.ch> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: maxime.chevallier@bootlin.com Hi Andrew, On Fri, 15 Dec 2023 10:46:18 +0100 Andrew Lunn wrote: > > I disagree with that - analysing the locking and coming up with a fix > > is likely going to be a lengthy affair, meanwhile the mainline kernel > > will deadlock on this. This patch prevents that deadlock at the > > expense of removing the LED triggers for the PHY-on-SFP which I don't > > think is a big deal considering the age of the PHY-based LED triggers. > > > > So I personally would prefer this patch to be merged while a > > different solution (that we have little idea at this point what it > > would look like) is sought. I would agree, I feel bad about delaying it , although as Daniel mentioned it's indeed the trigger registration that gets skipped. > So, if i'm reading this patch correctly, it only affects PHYs within > SFPs. > > The discussion went off on a tangent and also talked about media > converter PHYs, but from my reading of this patch, they are unaffected > by this patch. Do they however also suffer from this deadlock? Anybody > tested that? I can give it a try today (in a few hours probably, I'm experiencing a power outage right now...) and make sure the issue doesn't occur with media converter PHYs. Maxime > Andrew