From: Florian Westphal <fw@strlen.de>
To: "D. Wythe" <alibuda@linux.alibaba.com>
Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, coreteam@netfilter.org,
netfilter-devel@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
ast@kernel.org
Subject: Re: [RFC nf-next v1 1/2] netfilter: bpf: support prog update
Date: Fri, 15 Dec 2023 15:17:12 +0100 [thread overview]
Message-ID: <20231215141712.GA17065@breakpoint.cc> (raw)
In-Reply-To: <1702609653-45835-2-git-send-email-alibuda@linux.alibaba.com>
D. Wythe <alibuda@linux.alibaba.com> wrote:
> const struct nf_defrag_hook *defrag_hook;
> + const struct bpf_prog __rcu *nf_prog;
Hmm, why do we need this pointer?
Can't you just re-use bpf_nf_link->link.prog?
> + rcu_assign_pointer(nf_link->nf_prog, new_prog);
> + old_prog = xchg(&link->prog, new_prog);
This looks redundant, I think you can remove the nf_prog
pointer again.
Rest LGTM.
next prev parent reply other threads:[~2023-12-15 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 3:07 [RFC nf-next v1 0/2] netfilter: bpf: support prog update D. Wythe
2023-12-15 3:07 ` [RFC nf-next v1 1/2] " D. Wythe
2023-12-15 14:17 ` Florian Westphal [this message]
2023-12-18 3:06 ` D. Wythe
2023-12-15 3:07 ` [RFC nf-next v1 2/2] selftests/bpf: Add netfilter link prog update test D. Wythe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215141712.GA17065@breakpoint.cc \
--to=fw@strlen.de \
--cc=alibuda@linux.alibaba.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).