[PATCH RFC net-next 0/2] Add en8811h phy driver and devicetree binding doc

[PATCH RFC net-next 0/2] Add en8811h phy driver and devicetree binding doc

[Eric Woudstra]

Add the Airoha EN8811H 2.5 Gigabit PHY.

The phy supports 100/1000/2500 Mbps with auto negotiotion only.

The driver uses two firmware files, which are added to linux-firmware already.

This patch series adds the driver and the devicetree binding documentation.

Eric Woudstra (2):
  Add en8811h bindings documentation yaml
  Add the Airoha EN8811H PHY driver

 .../bindings/net/airoha,en8811h.yaml          |   42 +
 drivers/net/phy/Kconfig                       |    5 +
 drivers/net/phy/Makefile                      |    1 +
 drivers/net/phy/air_en8811h.c                 | 1044 +++++++++++++++++
 4 files changed, 1092 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/airoha,en8811h.yaml
 create mode 100644 drivers/net/phy/air_en8811h.c

-- 
2.42.1

[PATCH RFC net-next 1/2] Add en8811h bindings documentation yaml

[Eric Woudstra]

The en8811h phy can be set with serdes polarity reversed on rx and/or tx.

Signed-off-by: Eric Woudstra <ericwouds@gmail.com>
---
 .../bindings/net/airoha,en8811h.yaml          | 42 +++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/airoha,en8811h.yaml

diff --git a/Documentation/devicetree/bindings/net/airoha,en8811h.yaml b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml
new file mode 100644
index 000000000000..96febd8ed6fa
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/airoha,en8811h.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Airoha EN8811H PHY
+
+maintainers:
+  - Someone <someone@somemail.com>
+
+description:
+  Bindings for Airoha EN8811H PHY
+
+allOf:
+  - $ref: ethernet-phy.yaml#
+
+properties:
+  airoha,rx-pol-reverse:
+    type: boolean
+    description:
+      Reverse rx polarity of SERDES.
+
+
+  airoha,tx-pol-reverse:
+    type: boolean
+    description:
+      Reverse tx polarity of SERDES.
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    mdio {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        ethphy1: ethernet-phy@1 {
+                reg = <1>;
+                airoha,rx-pol-reverse;
+        };
+    };
-- 
2.42.1

Re: [PATCH RFC net-next 1/2] Add en8811h bindings documentation yaml

[Andrew Lunn]

On Sat, Dec 16, 2023 at 08:43:17PM +0100, Eric Woudstra wrote:
> The en8811h phy can be set with serdes polarity reversed on rx and/or tx.
> 
> Signed-off-by: Eric Woudstra <ericwouds@gmail.com>
> ---
>  .../bindings/net/airoha,en8811h.yaml          | 42 +++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/airoha,en8811h.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/airoha,en8811h.yaml b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml
> new file mode 100644
> index 000000000000..96febd8ed6fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/airoha,en8811h.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Airoha EN8811H PHY
> +
> +maintainers:
> +  - Someone <someone@somemail.com>
> +
> +description:
> +  Bindings for Airoha EN8811H PHY
> +
> +allOf:
> +  - $ref: ethernet-phy.yaml#
> +
> +properties:
> +  airoha,rx-pol-reverse:
> +    type: boolean
> +    description:
> +      Reverse rx polarity of SERDES.
> +
> +
> +  airoha,tx-pol-reverse:
> +    type: boolean
> +    description:
> +      Reverse tx polarity of SERDES.

Is this to deal with wiring up the SERDES backwards? Is there a more
detailed description in the data sheet?

   Andrew

Re: [PATCH RFC net-next 1/2] Add en8811h bindings documentation yaml

[Eric Woudstra]

> 
> Is this to deal with wiring up the SERDES backwards? Is there a more
> detailed description in the data sheet?
> 

Sadly, I have not received the datasheet. All comes from studying different versions of the driver.

On the BananiPi-R3 Mini the RX pair is reversed:

	phy14: ethernet-phy@14 {
		reg = <14>;
		interrupts-extended = <&pio 48 IRQ_TYPE_EDGE_FALLING>;
		reset-gpios = <&pio 49 GPIO_ACTIVE_LOW>;
		reset-assert-us = <10000>;
		reset-deassert-us = <20000>;
		phy-mode = "2500base-x";
		full-duplex;
		pause;
		airoha,rx-pol-reverse;

		leds {
			#address-cells = <1>;
			#size-cells = <0>;

			led@0 { /* en8811_a_gpio5 */
				reg = <0>;
				color = <LED_COLOR_ID_YELLOW>;
				function = LED_FUNCTION_LAN;
				function-enumerator = <1>;
				default-state = "keep";
				linux,default-trigger = "netdev";
			};
			led@1 { /* en8811_a_gpio4 */
				reg = <1>;
				color = <LED_COLOR_ID_GREEN>;
				function = LED_FUNCTION_LAN;
				function-enumerator = <2>;
				default-state = "keep";
				linux,default-trigger = "netdev";
			};
		};
	};

Re: [PATCH RFC net-next 1/2] Add en8811h bindings documentation yaml

[Krzysztof Kozlowski]

On 16/12/2023 20:43, Eric Woudstra wrote:
> The en8811h phy can be set with serdes polarity reversed on rx and/or tx.
> 
> Signed-off-by: Eric Woudstra <ericwouds@gmail.com>
> ---

Why duplicated patchsets? Nothing improved here.

Best regards,
Krzysztof

[PATCH RFC net-next 1/2] Add en8811h bindings documentation yaml

[Eric Woudstra]

The en8811h phy can be set with serdes polarity reversed on rx and/or tx.

Signed-off-by: Eric Woudstra <ericwouds@gmail.com>
---
 .../bindings/net/airoha,en8811h.yaml          | 42 +++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/airoha,en8811h.yaml

diff --git a/Documentation/devicetree/bindings/net/airoha,en8811h.yaml b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml
new file mode 100644
index 000000000000..96febd8ed6fa
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/airoha,en8811h.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Airoha EN8811H PHY
+
+maintainers:
+  - Someone <someone@somemail.com>
+
+description:
+  Bindings for Airoha EN8811H PHY
+
+allOf:
+  - $ref: ethernet-phy.yaml#
+
+properties:
+  airoha,rx-pol-reverse:
+    type: boolean
+    description:
+      Reverse rx polarity of SERDES.
+
+
+  airoha,tx-pol-reverse:
+    type: boolean
+    description:
+      Reverse tx polarity of SERDES.
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    mdio {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        ethphy1: ethernet-phy@1 {
+                reg = <1>;
+                airoha,rx-pol-reverse;
+        };
+    };
-- 
2.42.1

Re: [PATCH RFC net-next 1/2] Add en8811h bindings documentation yaml

[Krzysztof Kozlowski]

On 16/12/2023 20:44, Eric Woudstra wrote:
> The en8811h phy can be set with serdes polarity reversed on rx and/or tx.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

A nit, subject: drop second/last, redundant "bindings documentation
yaml". The "dt-bindings" prefix is already stating that these are
bindings. Quite redundant/useless subject.

> 
> Signed-off-by: Eric Woudstra <ericwouds@gmail.com>
> ---
>  .../bindings/net/airoha,en8811h.yaml          | 42 +++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/airoha,en8811h.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/airoha,en8811h.yaml b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml
> new file mode 100644
> index 000000000000..96febd8ed6fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/airoha,en8811h.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Airoha EN8811H PHY
> +
> +maintainers:
> +  - Someone <someone@somemail.com>
> +
> +description:
> +  Bindings for Airoha EN8811H PHY

Drop "Bindings for" and instead describe the hardware. Don't copy the
title, what's the point in this?

> +
> +allOf:
> +  - $ref: ethernet-phy.yaml#
> +
> +properties:
> +  airoha,rx-pol-reverse:
> +    type: boolean
> +    description:
> +      Reverse rx polarity of SERDES.
> +
> +

No, that won't work. Your schema is not being applied. Look at patches
on the mailing list for the phys.


Why do I see multiple patchsets of this?

Best regards,
Krzysztof