From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 1/3] tools: ynl-gen: use correct len for string and binary
Date: Mon, 18 Dec 2023 14:22:09 -0800 [thread overview]
Message-ID: <20231218142209.64b0a2ab@kernel.org> (raw)
In-Reply-To: <ZX1hXMhJLwgg5S1v@Laptop-X1>
On Sat, 16 Dec 2023 16:35:40 +0800 Hangbin Liu wrote:
> The max-len / min-len / extact-len micro are used by binary. For string we
> need to use "len" to define the max length. e.g.
>
> static const struct nla_policy
> team_nl_option_policy[TEAM_ATTR_OPTION_MAX + 1] = {
> [TEAM_ATTR_OPTION_UNSPEC] = { .type = NLA_UNSPEC, },
> [TEAM_ATTR_OPTION_NAME] = {
> .type = NLA_STRING,
> .len = TEAM_STRING_MAX_LEN,
> },
max-len / min-len / extact-len are just the names in the spec.
We can put the value provided in the spec as max-len inside
nla_policy as len, given that for string spec::max-len == policy::len
Am I confused?
next prev parent reply other threads:[~2023-12-18 22:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 3:50 [PATCH net-next 0/3] ynl-gen: update check format Hangbin Liu
2023-12-15 3:50 ` [PATCH net-next 1/3] tools: ynl-gen: use correct len for string and binary Hangbin Liu
2023-12-16 2:06 ` Jakub Kicinski
2023-12-16 8:35 ` Hangbin Liu
2023-12-18 22:22 ` Jakub Kicinski [this message]
2023-12-19 10:01 ` Hangbin Liu
2023-12-15 3:50 ` [PATCH net-next 2/3] tools: ynl-gen: support using defines in checks Hangbin Liu
2023-12-16 2:08 ` Jakub Kicinski
2023-12-16 8:44 ` Hangbin Liu
2023-12-18 22:23 ` Jakub Kicinski
2023-12-15 3:50 ` [PATCH net-next 3/3] netlink: specs: use exact-len for IPv6 addr Hangbin Liu
2023-12-16 2:09 ` Jakub Kicinski
2023-12-16 8:48 ` Hangbin Liu
2023-12-18 22:24 ` Jakub Kicinski
2023-12-18 11:40 ` Davide Caratti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218142209.64b0a2ab@kernel.org \
--to=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).