From: Simon Horman <horms@kernel.org>
To: Suman Ghosh <sumang@marvell.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Geethasowjanya Akula <gakula@marvell.com>,
Hariprasad Kelam <hkelam@marvell.com>,
Linu Cherian <lcherian@marvell.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [net-next PATCH] octeontx2-af: Add new devlink param to configure maximum usable NIX block LFs
Date: Mon, 18 Dec 2023 19:10:51 +0000 [thread overview]
Message-ID: <20231218191051.GL6288@kernel.org> (raw)
In-Reply-To: <SJ0PR18MB521600A9A06C7306FE28E014DB90A@SJ0PR18MB5216.namprd18.prod.outlook.com>
On Mon, Dec 18, 2023 at 06:03:53PM +0000, Suman Ghosh wrote:
> >Hi Suman,
> >
> >I realise that this patch has been accepted.
> >But I believe there is a double-free problem above as mcam-
> >>counters.bmap may be freed twice.
> >And mcam->bmap seems to be leaked.
> >
> >Perhaps the last part of the unwind ladder should be:
> >
> >free_bmap:
> > kfree(mcam->bmap);
> >
> >Double-free flagged by Smatch and Coccinelle.
> [Suman] Thanks Simon for finding it. I have pushed a follow-up patch as a fix.
Likewise, thanks. The fix patch looks good.
prev parent reply other threads:[~2023-12-18 19:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 12:01 [net-next PATCH] octeontx2-af: Add new devlink param to configure maximum usable NIX block LFs Suman Ghosh
2023-12-17 20:13 ` patchwork-bot+netdevbpf
2023-12-18 16:23 ` Simon Horman
2023-12-18 18:03 ` [EXT] " Suman Ghosh
2023-12-18 19:10 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218191051.GL6288@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).